Short code

[VBABEGINER]

ANy other way to write this code..

ActiveWorkbook.Sheets("Sur").Columns("R:R").Select
Selection.Insert Shift:=xlToRight
Columns("S:S").Select
Selection.Copy
Columns("R:R").Select
Selection.PasteSpecial Paste:=xlPasteValuesAndNumberFormats, Operation:=xlNone, SkipBlanks:=False, Transpose:=False
Application.CutCopyMode = False

 

[ParamRay]

Sub Test()
  With ThisWorkbook.Sheets("Sur")
    .Columns("R").Insert Shift:=xlToRight
    .Columns("S").Copy
    .Columns("R").PasteSpecial xlPasteValuesAndNumberFormats
    Application.CutCopyMode = False
  End With
End Sub

 

[Eric W]

Also:

    Columns("R:R").Select
    Selection.Copy
    Selection.Insert Shift:=xlToRight

This assumes the Sur sheet is already active.

 

[Rick Rothstein]

I think this should also work (also assuming the Sur sheet is active)...

[S:S].Insert
[R:R].Copy [S1]

 

[VBABEGINER]

Wow Thanks..
For this..

Workbooks("QDC.xlsb").Activate
'ActiveWorkbook.Sheets("Sur").Columns("E:E").Select
ActiveWorkbook.Sheets("Sur").Columns("D:D").Select
Selection.Insert Shift:=xlToRight
Selection.Insert Shift:=xlToRight
Columns("D:D").Select
Selection.Copy
Range("AK1").Select
Selection.PasteSpecial Paste:=xlPasteValuesAndNumberFormats, Operation:=xlNone, SkipBlanks:=False, Transpose:=False
Application.CutCopyMode = False

Any idea pls

 

[Rick Rothstein]

Wow Thanks..
For this..

Workbooks("QDC.xlsb").Activate
'ActiveWorkbook.Sheets("Sur").Columns("E:E").Select
ActiveWorkbook.Sheets("Sur").Columns("D:D").Select
Selection.Insert Shift:=xlToRight
Selection.Insert Shift:=xlToRight
[B][COLOR="#FF0000"]Columns("D:D").Select
Selection.Copy[/COLOR][/B]
Range("AK1").Select
Selection.PasteSpecial Paste:=xlPasteValuesAndNumberFormats, Operation:=xlNone, SkipBlanks:=False, Transpose:=False
Application.CutCopyMode = False

Any idea pls

Once you have selected Column D and shifted right twice, there is nothing in Column D to copy to Column AK. What exactly is this code supposed to be doing?

 

[VBABEGINER]

Yes...Col D after 2 columns inserting...Col D Copy to AK to do Text to Column..
Data in Col D

6/1/2018  2:19:41 PM

Ak wil get 6/1/2018
Al wil also get 6/1/2018
Al wil get 2:19:41 PM

Copy AK and AI in Col D and E.

 

[ParamRay]

Just throwing it out there, but does anyone else think it's bad practice to make assumptions about which sheet/workbook is active, and inefficient to be selecting objects (such as ranges) in order to work with them?

 

[Rick Rothstein]

Yes...Col D after 2 columns inserting...Col D Copy to AK to do Text to Column..
Data in Col D

6/1/2018  2:19:41 PM

Ak wil get 6/1/2018
Al wil also get 6/1/2018
Al wil get 2:19:41 PM

Copy AK and AI in Col D and E.

Please reread your code, especially the first active line of code (not the one you commented out which I think may be the line you actually want to be active) and then reread my comment again.

 

[Eric W]

Both salient points, @ParamRay. Perhaps the shortest way to handle the original request with your points would be to modify Rick's code as follows:

    Sheets("Sur").Columns("S").Insert
    Sheets("Sur").Columns("R").Copy Sheets("Sur").Range("S1")

My original snippet still had a Select in it. Since VBABEGINER's original code also required that the Sur sheet be selected, I didn't see a problem with my code also requiring that, but I did think it would be beneficial to explicitly comment on it. I could have spent more time finding a way to remove the Select from my code, but I had time constraints, and since my snippet was already 4 lines shorter than the original, I felt it worthwhile to post.