Search code - See any issues?

[erutherford]

found this piece code and its exactly as presented. It works in the provider demo, but not in my new workbook.

Error occurs at the bold red print (object define error)

Sub search_and_extract_singlecriteria()
Dim datasheet As Worksheet
Dim reportsheet As Worksheet
Dim typename As String
Dim finalrow As Integer
Dim i As Integer

'set variables
Set datasheet = Sheet1
Set reportsheet = Sheet2
typename = reportsheet.Range("B2").Value

'clear old data
reportsheet.Range("A5:L100").ClearContents

'goto datasheet and start searching and copying
datasheet.Select
finalrow = Cells(Rows.Count, 1).End(x1Up).Row

For i = 2 To finalrow
    If Cells(i, 2) = typename Then
    Range(Cells(i, 1), Cells(i, 12)).Copy
    reportsheet.Select
    Range("A200").End(x1Up).Offset(1, 0).PasteSpecial xlPasteFormulasAndNumberFormats
    datasheet.Select
    End If
Next i

reportsheet.Select

Range("B2").Select

End Sub

 

[Rick Rothstein]

finalrow = Cells(Rows.Count, 1).End(x1Up).Row

You have x1Up (with the number 1)... it should be xlUp (with the letter L).

 

[erutherford]

thank you! Sometimes its just right in front of you!

 

[Rick Rothstein]

thank you! Sometimes its just right in front of you!

It is a long-standing problem with the VB editor's font... ones and L's look alike as do zeros and O's.

 

[erutherford]

Still doing a little troubleshooting on this piece of code, now that all the typos are fixed. I've stepped through the macro and everything functions correctly except the red highlighted area (most important piece!)

Sub search_and_extract_singlecriteria()
Dim datasheet As Worksheet
Dim reportsheet As Worksheet
Dim typename As String
Dim finalrow As Integer
Dim i As Integer

'set variables
Set datasheet = Sheet1
Set reportsheet = Sheet2
typename = reportsheet.Range("B2").Value

'clear old data
reportsheet.Range("A5:L100").ClearContents

'goto datasheet and start searching and copying
datasheet.Select
finalrow = Cells(Rows.Count, 1).End(x1Up).Row

For i = 2 To finalrow
    If Cells(i, 2) = typename Then
    Range(Cells(i, 1), Cells(i, 9)).Copy
    reportsheet.Select
    Range("A200").End(x1Up).Offset(1, 0).PasteSpecial xlPasteFormulasAndNumberFormats
    datasheet.Select
    End If
Next i

reportsheet.Select

 

[Fluff]

Other than you still have x1up not xlup in two places, what is not working?

 

[erutherford]

I did fix those last night (pasted the wrong version) Those "1" show up better here!

correct version

Sub search_and_extract_singlecriteria()
Dim datasheet As Worksheet
Dim reportsheet As Worksheet
Dim typename As String
Dim finalrow As Integer
Dim i As Integer

'set variables
Set datasheet = Sheet1
Set reportsheet = Sheet2
typename = reportsheet.Range("B2").Value

'clear old data
reportsheet.Range("A5:I25").ClearContents

'goto datasheet and start searching and copying
datasheet.Select
finalrow = Cells(Rows.Count, 1).End(xlUp).Row

For i = 2 To finalrow
    If Cells(i, 2) = typename Then
    Range(Cells(i, 1), Cells(i, 9)).Copy
    reportsheet.Select
    Range("A25").End(xlUp).Offset(1, 0).PasteSpecial Paste:=xlPasteValuesAndNumberFormats
    datasheet.Select
    End If
Next i

reportsheet.Select

Range("B2").Select

End Sub

The code its not performing the search, displaying, then pasting

 

[Fluff]

When you step through the code what is it doing?

 

[MARK858]

Is it right that you are pasting to the next blank cell after any data above cell A25?

 

[erutherford]

It is suppose to find the first blank row then paste. If it help here is the link where I found the video of the code I am trying to use.

https://www.youtube.com/watch?v=-QFjJoRGCtU&t=181s