Scripting Dictionary Byref Type Mismatch Error

[avd88]

Hi,

Trying to loop through key-value pairs in a data dictionary and use those values in a sub I'm calling but keep getting the error Byref Type Mismatch. Can't figure out what the problem is.
Any ideas?

This is the sub I'm calling:

Sub DropDown(o As MSForms.ComboBox, r As String)
Dim I As Worksheet
    Set I = Worksheets("Inputs")
   
    o.List = I.Range(r).Value
End Sub

The sub works perfectly when implemented like this:

'DJOHS DROPDOWN'
    Call DropDown(SDJOHSComboBox, "DJOHS")
    Call DropDown(LDJOHSComboBox, "DJOHS")

What I'm trying to do is create a data dictionary with all the key - item pairs and loop through that sub. Something like this:

Dim iDict As New Scripting.dictionary
   
    'Create a Dictionary Object
    iDict.Add "SStageComboBox", "Stage"
    iDict.Add "SYearComboBox", "Year"
    iDict.Add "LYearComboBox", "Year"
    iDict.Add "SPeriodComboBox", "Period"
    iDict.Add "LPeriodComboBox", "Period"
   
    'Loop Thru each key item pair
    For Each I In iDict.Keys
        Call DropDown(iDict.Keys(I), iDict.Items(I))
    Next I

The error is flagging this portion of the code:

iDict.Keys(I)

Tried removing the "" on the dictionary keys as those are used as a ComboBox object in the sub but that didn't really work.

 

[kennypete]

Syntax? Without testing, does this work?

For Each I In iDict.Keys
        Call DropDown(I, iDict(I))
Next I

 

[dmt32]

Hi,
try passing your arguments ByVal & see if this resolves your issue

Sub DropDown(ByVal o As MSForms.ComboBox, ByVal r As String)
Dim I As Worksheet
    Set I = Worksheets("Inputs")
  
    o.List = I.Range(r).Value
End Sub

Dave

 

[avd88]

Tried the suggestions separately and it did not work, but a combination of the two of them worked perfectly! TEAMWORK!!!

Thank you very much friends!