Save Workbook VBA

[JohnZ1156]

I have a macro to print out a page. Then I have this at the very end of my macro.
But after I get the message box that the Workbook has been saved, and I press "OK". when I go to close the workbook by clicking on the red "X" in the top right hand corner, it asks me if I want to save the Workbook. Why?

    MsgBox ("The " & Left(ActiveWorkbook.Name, Len(ActiveWorkbook.Name) - 5) & " Workbook was saved!")
    ThisWorkbook.Save

End Sub

 

[LazyBug]

Hello!

In a message box you talk about ActiveWorkbook, but the macro saves ThisWorkbook. ThisWorkbook is always a reference to the book in which the code is written. ActiveWorkbook - open and activated book at the moment of macro execution. So, try

ActiveWorkbook.Save
MsgBox ("The " & Left(ActiveWorkbook.Name, Len(ActiveWorkbook.Name) - 5) & " Workbook was saved!")

or

ActiveWorkbook.Close 1
MsgBox ("The " & Left(ActiveWorkbook.Name, Len(ActiveWorkbook.Name) - 5) & " Workbook was saved!")

to close your book without mouse clicking.

 

[JohnZ1156]

Hi LazyBug

Thanks for your help.
After the macro prints and saves, I'd rather NOT automatically close the WorkBook. Just in case I want to look at something else.

But, even after changing to your script,
ActiveWorkbook.Save
MsgBox ("The " & Left(ActiveWorkbook.Name, Len(ActiveWorkbook.Name) - 5) & " Workbook was saved!")
and the WorkBook has been saved, when I click on the "X" in the upper right hand corner to close the WorkBook and exit Excel completely, I still get the window asking me if I want to Save the Workbook.

I even tried "swapping" your lines of code to:
MsgBox ("The " & Left(ActiveWorkbook.Name, Len(ActiveWorkbook.Name) - 5) & " Workbook was saved!")
ActiveWorkbook.Save

 

[LazyBug]

Hi LazyBug

Thanks for your help.
After the macro prints and saves, I'd rather NOT automatically close the WorkBook. Just in case I want to look at something else.

But, even after changing to your script,
ActiveWorkbook.Save
MsgBox ("The " & Left(ActiveWorkbook.Name, Len(ActiveWorkbook.Name) - 5) & " Workbook was saved!")
and the WorkBook has been saved, when I click on the "X" in the upper right hand corner to close the WorkBook and exit Excel completely, I still get the window asking me if I want to Save the Workbook.

I even tried "swapping" your lines of code to:
MsgBox ("The " & Left(ActiveWorkbook.Name, Len(ActiveWorkbook.Name) - 5) & " Workbook was saved!")
ActiveWorkbook.Save

I have not been able to reproduce the situation in my file. Maybe you could post the macro text in full?