Run Time Error 28 - Out of Stack Space

[BKrukowski]

I as receiving a run time 28 error when I use a loop to fill a collection of class objects. The error occurs on line .Profit = ActiveCell.Offset(0, 3).value.
I have tried many references about this and they do not seem to apply to my code (I am not calling excessive Subs, I do not believe I have a recursive trigger (unless Setting class objects is a recursive trigger). When I look at the Stack only two things appear - the Sub I am running and something called [<non-basic Code="">]

Prior to the code below I a
assign variable to take the UserForm Controls values
Resize and Fill cells (with Selection.Interior)
Go to a different Sheet - this is a table of data that are attributes to the class object cReslEstate

Set GameRealEstate = New Collection
'Populate Real Estate randomly
i = 1
    
    For i = 1 To PropCount
    
       Set ReProp = New cRealEstate
       
        ActiveCell.Offset(Int(100 - 1 + 1) * Rnd + 1).Activate
        
        With ReProp
            .Name = ActiveCell.value
            .Cost = ActiveCell.Offset(0, 1).value
            .Rent = ActiveCell.Offset(0, 2).value
            .Profit = ActiveCell.Offset(0, 3).value
            .Mort = ActiveCell.Offset(0, 4).value
        End With
        
        
        Range("A:A").Find(GLoc).Activate 
        ActiveCell.Offset(0, 1).Activate
                
  Next I

</non-basic>

 

[StephenCrump]

I as receiving a run time 28 error when I use a loop to fill a collection of class objects. <non-basic code=""></non-basic>

Welcome to the Forum!

Can you post your code for the cRealEstate class? My guess is that you're triggering a recursive call in that code.

By the way, this loop isn't adding anything to the Collection. It's just overwriting ReProp with new instances of cRealEstate.

 

[BKrukowski]

Welcome to the Forum!

Can you post your code for the cRealEstate class? My guess is that you're triggering a recursive call in that code.

By the way, this loop isn't adding anything to the Collection. It's just overwriting ReProp with new instances of cRealEstate.

Hi Stephen,

Thank you for your help, below is my Class Module for cRealEstate. Also I have added GameRealEstate.Add ReProp after the End With statement.
When I tried to add a Key GameRealEstate.Add (ReProp, ReProp.Name) I received an compiler error expecting := expression when I add it by (Item:=ReProp, Key:=ReProp.Name) I get Compile error Expected :=

'Define New Class for Properties
Private reName As String
Private reCost As Integer
Private reRent As Integer
Private reProfit As Integer
Private reMort As Integer
Private reOwner As StringPublic Property Get Name() As String
    Name = reName
End Property
Public Property Let Name(value As String)
If Len(value) > 1 Then
    reName = value
End If
End Property
Public Property Get Cost() As Integer
    Cost = reCost
End Property
'LET
Public Property Let Cost(value As Integer)
If value > 0 Then
    reCost = value
End If
End Property
Public Property Get Rent() As Integer
    Rent = reRent
End Property
'LET
Public Property Let Rent(value As Integer)
If value > 0 Then
    reRent = value
End If
End Property
Public Property Get Profit() As Integer
    Profit = reProfit
End Property
'LET
Public Property Let Profit(value As Integer)
    Profit = value
End Property
Public Property Get Mort() As Integer
    Mort = reMort
End Property
'LET
Public Property Let Mort(value As Integer)
If value > 0 Then
    reMort = value
End If
End Property
Public Property Get Owner() As String
    Owner = reOwner
End Property
Public Property Let Owner(value As String)
If Len(value) > 0 Then
    reOwner = value
End If
End Property

 

[RoryA]

Your Profit Let property is calling itself. It should be:

Public Property Let Profit(value As Integer)
    reProfit = value
End Property

and not:

Public Property Let Profit(value As Integer)
    Profit = value
End Property

 

[BKrukowski]

Thank you Rory,
You have solved the Stack Out of Space error, Do you know why Public Property Let did not show up in the call stack view?
Do you have any thoughts on the compile error when I try to add to the collection?

 

[RoryA]

Can you post the actual code you used when adding to the Collection?

 

[RoryA]

Do you know why Public Property Let did not show up in the call stack view?

I'd assume you don't have your VBE set up to break in class modules when there's an error. That's why all you see is the code running in the calling module.

 

[BKrukowski]

Right now I have

Set GameRealEstate = New Collection
'Populate Real Estate randomly
i = 1
    
    For i = 1 To PropCount
    
       Set ReProp = New cRealEstate
       
        ActiveCell.Offset(Int(100 - 1 + 1) * Rnd + 1).Activate
        
        With ReProp
            .Name = ActiveCell.value
            .Cost = ActiveCell.Offset(0, 1).value
            .Rent = ActiveCell.Offset(0, 2).value
            .Profit = ActiveCell.Offset(0, 3).value
            .Mort = ActiveCell.Offset(0, 4).value
        End With
        
        GameRealEstate.Add ReProp
                                       
        Range("A:A").Find(GLoc).Activate ' Go Back to the City Head
        ActiveCell.Offset(0, 1).Activate ' Go over to the names
                
  Next I

I wanted to use the Name Property as the ID, so I was trying

Set GameRealEstate = New Collection
'Populate Real Estate randomly
i = 1
    
    For i = 1 To PropCount
    
       Set ReProp = New cRealEstate
       
        ActiveCell.Offset(Int(100 - 1 + 1) * Rnd + 1).Activate
        
        With ReProp
            .Name = ActiveCell.value
            .Cost = ActiveCell.Offset(0, 1).value
            .Rent = ActiveCell.Offset(0, 2).value
            .Profit = ActiveCell.Offset(0, 3).value
            .Mort = ActiveCell.Offset(0, 4).value
        End With
        
        GameRealEstate.Add (ReProp, ReProp.Name)
        
                                       
        Range("A:A").Find(GLoc).Activate ' Go Back to the City Head
        ActiveCell.Offset(0, 1).Activate ' Go over to the names
                
  Next I

And I get a Compile Error Expecting:=

So I thought

GameRealEstate.Add (Item:= ReProp, Key:= ReProp.Name)

But I get the same error.

I took the syntax from multiple sources including Microsoft website

 

[RoryA]

You need to remove the parentheses as you aren't returning a value:

GameRealEstate.Add Item:=ReProp, Key:=ReProp.Name

 

[BKrukowski]

RoryA,

Thank you very much for your help. The issue is fixed because of your knowledge.