Refresh rowsource of a listbox

[thanasis380]

I have a range (Myrange) with three columns, the first two (eg Name, Address) are filled and the third (eg Age) will be filled through a form.
So I made a listbox with rowsource (Myrange) and the user will select his name and then an inputbox will ask for a numeric value.
The value is inserted in Myrange in the sheet and simultaneously the rowsource of the listbox is refreshed.
Unfortunately my code asks twice for the age. Any suggestions to solve that?
Thanks in advance.

<code style="margin: 0px; padding: 0px; border: 0px; font-style: inherit; font-variant: inherit; font-weight: inherit; font-stretch: inherit; line-height: inherit; font-family: Consolas, Menlo, Monaco, "Lucida Console", "Liberation Mono", "DejaVu Sans Mono", "Bitstream Vera Sans Mono", "Courier New", monospace, sans-serif; vertical-align: baseline; white-space: inherit;">PrivateSub UserForm_Initialize()
With ListBox1
.ColumnCount =3
.ColumnHeads =True
.ListStyle = fmListStyleOption
.MultiSelect = fmMultiSelectSingle
.RowSource ="Sheet1!A2:C6"
.ListIndex =-1
EndWith
EndSub

PrivateSub ListBox1_Click()
Dim Myrange AsString
Myrange = ListBox1.RowSource

For i =0To ListBox1.ListCount -1
If ListBox1.Selected(i)=TrueThen
ExitFor
Else
EndIf
Next i

x = Application.InputBox("Insert age")
y = ListBox1.ListIndex

ListBox1.RowSource = vbNullString
Sheets("Sheet1").Cells(y +2,3).Value = x
ListBox1.RowSource = Myrange
EndSub</code>

 

[Fluff]

Rather than using a listbox click event, add a command button & run the code that way.

Private Sub CommandButton1_Click()

Dim Myrange As String

Myrange = ListBox1.RowSource

For i = 0 To ListBox1.ListCount - 1
If ListBox1.Selected(i) = True Then
Exit For
Else
End If
Next i

x = Application.InputBox("Insert age")
y = ListBox1.ListIndex

ListBox1.RowSource = vbNullString
Sheets("Page1").Cells(y + 2, 3).Value = x
ListBox1.RowSource = Myrange
End Sub

 

[thanasis380]

Thank you Fluff for your reply.
It works, but my original idea was to have one click (only selecting the row) instead of two (selecting row and clicking button).
Do you have any idea why the inputbox appears twice?

 

[Fluff]

Your last line of code is updating the listbox, which is acting as a click event & therefore causes the event to run again.

 

[Fluff]

Another option is

Private Sub ListBox1_AfterUpdate()
Dim Myrange As String

Myrange = ListBox1.RowSource

[COLOR=#0000ff]'For i = 0 To ListBox1.ListCount - 1
'If ListBox1.Selected(i) = True Then
'Exit For
'Else
'End If
'Next i[/COLOR]

x = Application.InputBox("Insert age")
y = ListBox1.ListIndex

ListBox1.RowSource = vbNullString
Sheets("Page1").Cells(y + 2, 3).Value = x
ListBox1.RowSource = Myrange

End Sub

Also, the lines in blue are redundant, so you can delete them.

 

[MickG]

This is another option :-

Private [COLOR="Navy"]Sub[/COLOR] UserForm_Initialize()
[COLOR="Navy"]With[/COLOR] ListBox1
    .ColumnCount = 3
    .ColumnHeads = True
    .ListStyle = fmListStyleOption
    .MultiSelect = fmMultiSelectSingle
    .List = Sheets("Sheet1").Range("A2:C6").Value
    .ListIndex = -1
[COLOR="Navy"]End[/COLOR] With
[COLOR="Navy"]End[/COLOR] [COLOR="Navy"]Sub[/COLOR]

Private [COLOR="Navy"]Sub[/COLOR] ListBox1_Click()
[COLOR="Navy"]Dim[/COLOR] i [COLOR="Navy"]As[/COLOR] [COLOR="Navy"]Long,[/COLOR] X [COLOR="Navy"]As[/COLOR] [COLOR="Navy"]Long,[/COLOR] Rw [COLOR="Navy"]As[/COLOR] [COLOR="Navy"]Long[/COLOR]
[COLOR="Navy"]For[/COLOR] i = 0 To ListBox1.ListCount - 1
    [COLOR="Navy"]If[/COLOR] ListBox1.Selected(i) = True [COLOR="Navy"]Then[/COLOR]
        Rw = i
        X = Application.InputBox("Insert age")
        ListBox1.List(Rw, 2) = X
        Sheets("Sheet1").Cells(Rw + 2, 3).Value = X
        [COLOR="Navy"]Exit[/COLOR] For
    [COLOR="Navy"]End[/COLOR] If
[COLOR="Navy"]Next[/COLOR] i
[COLOR="Navy"]End[/COLOR] [COLOR="Navy"]Sub[/COLOR]

Regards Mick

 

[thanasis380]

Fluff and MickG thank you very much. You are very helpful.

 

[Fluff]

Glad we could help & thanks for the feedback

 

[MickG]

You're welcome