Receiving Error Message on VBA Code

[findingcindy]

I have the following code that loops through a list of 150+ store numbers on "Lookup Data" tab, changes b4 cell on the "Scorecard" tab to the store number to populate the current data for that store, then exports the "Scorecard" tab plus the chart tab (which auto-populates to that store number) to a PDF with the store number as the file name. I keep getting a Compile Error : Invalid outside procedure. The export function works properly and the looping function works properly but when I put them together, I get that error. Thank you for any help you can offer. I've been struggling with this for hours.

Dim i As Long, LastRow As Long
Dim SaveLocation As String
Dim rng As Range

SaveLocation = "C:\Users\cindy\OneDrive\Desktop\Consulting"

Set rng = Worksheets("Scorecard").Range("A1:h43")

LastRow = Worksheets("Lookup Tables").Range("A500").End(xlUp).Row


For i = 1 To LastRow

If Not Worksheets("Lookup Tables").Range("A" & i).Value = 0 Then
    Worksheets("Scorecard").Range("b4").Value = Worksheets("Lookup Tables").Range("A" & i).Value
    Sheets(Array("Scorecard", "Chart")).Select
    Sheets("Scorecard").Activate
    
    ActiveWorkbook.ExportAsFixedFormat Type:=xlTypePDF, Filename:= _
        SaveLocation & Range("b4").Value, Quality:= _
        xlQualityStandard, IncludeDocProperties:=False, IgnorePrintAreas:=False, _
        openafterpublish:=True
End If
Next i

End Sub

 

[Joe4]

Welcome to the Board!

It seems to be suggesting that you have some lines of code outside of procedures. All your code must be between the "Sub" and "End Sub" lines.
If you cannot find it yourself, please post ALL your code (which I don't think you did because I do not see any "Sub" line at the beginning).

 

[findingcindy]

I think I fat-fingered that. This is the whole code. Thanks for looking at it!

Sub PrintCerts()

Dim i As Long, LastRow As Long
Dim SaveLocation As String
Dim rng As Range

SaveLocation = "C:\Users\Cindy.Montgomery\OneDrive - USDA\Desktop"

Set rng = Worksheets("Scorecard").Range("A1:M39")

LastRow = Worksheets("Data").Range("A500").End(xlUp).Row


For i = 1 To LastRow

If Not Worksheets("Data").Range("A" & i).Value = 0 Then
    Worksheets("Scorecard").Range("C4").Value = Worksheets("Data").Range("A" & i).Value
    Sheets(Array("Scorecard", "Chart")).Select
    Sheets("Scorecard").Activate
    ActiveWindow.SmallScroll Down:=10
    ActiveWorkbook.ExportAsFixedFormat Type:=xlTypePDF, Filename:= _
        SaveLocation & Range("C4").Value, Quality:= _
        xlQualityStandard, IncludeDocProperties:=False, IgnorePrintAreas:=False, _
        openafterpublish:=True
End If
Next i

       

End Sub

 

[findingcindy]

Welcome to the Board!

It seems to be suggesting that you have some lines of code outside of procedures. All your code must be between the "Sub" and "End Sub" lines.
If you cannot find it yourself, please post ALL your code (which I don't think you did because I do not see any "Sub" line at the beginning).

Whoops! This is not my my day for typing. Let's try that again!

Sub PrintScorecard

Dim i As Long, LastRow As Long
Dim SaveLocation As String
Dim rng As Range

SaveLocation = "C:\Users\cindy\OneDrive\Desktop\Consulting"

Set rng = Worksheets("Scorecard").Range("A1:h43")

LastRow = Worksheets("Lookup Tables").Range("A500").End(xlUp).Row


For i = 1 To LastRow

If Not Worksheets("Lookup Tables").Range("A" & i).Value = 0 Then
    Worksheets("Scorecard").Range("b4").Value = Worksheets("Lookup Tables").Range("A" & i).Value
    Sheets(Array("Scorecard", "Chart")).Select
    Sheets("Scorecard").Activate
    
    ActiveWorkbook.ExportAsFixedFormat Type:=xlTypePDF, Filename:= _
        SaveLocation & Range("b4").Value, Quality:= _
        xlQualityStandard, IncludeDocProperties:=False, IgnorePrintAreas:=False, _
        openafterpublish:=True
End If
Next i

End Sub

 

[Joe4]

You are missing the ellipses after your sub name, i.e.

Sub PrintScorecard

should be:

Sub PrintScorecard()

 

[bobsan42]

I believe the brackets are not the problem, the VBE will add it when you try to compile and not make a fuss about it. And in the first code paste there were brackets.
However , if the problem persists then this not ALL your code.
If this is all the code you need and use, check all other code modules (other modules, sheets, workbook, forms) for some misplaced line of code.

 

[Joe4]

I believe the brackets are not the problem, the VBE will add it when you try to compile and not make a fuss about it. And in the first code paste there were brackets.
However , if the problem persists then this not ALL your code.
If this is all the code you need and use, check all other code modules (other modules, sheets, workbook, forms) for some misplaced line of code.

Yeah, I see that if you try to add it without typing them in, it adds the for you automatically (which is curious that the code they posted does not show them, if they TRULY copy/pasted it here).
I think you are probably right, it is probably code somewhere else in their workbook.

 

[bobsan42]

(which is curious that the code they posted does not show them, if they TRULY copy/pasted it here).

the Sub name is changed - maybe during posting here