Public sub in a userform? Why is it not possible, or is it?

[finaljustice]

Hi there,

I am having a simple issue, I am not being able to call a sub that is in another userform.
On userform1 I have this sub I use to load information to the userform.
(It was before declared as Private, but I thought if I declared it as Public It would solve the problem)

Public Sub loadresults()  'simply reload results and is located is in the userform1.
UserForm1.TextBox1 = Format(ThisWorkbook.Sheets("LD").Range("W28"), "Standard")
UserForm1.TextBox2 = Format(ThisWorkbook.Sheets("LD").Range("P412"), "Standard") 
UserForm1.TextBox3 = Format(ThisWorkbook.Sheets("LD").Range("J15"), "Standard") 
UserForm1.TextBox4 = Format(ThisWorkbook.Sheets("LD").Range("J18"), "Standard") 
UserForm1.TextBox5 = Format(ThisWorkbook.Sheets("LD").Range("I22"), "Standard") 
UserForm1.TextBox6 = Format(ThisWorkbook.Sheets("LD").Range("J22"), "Standard") 
End Sub

Then on another userform2, I have a command button which called 2 subs like so:

Private Sub CommandButton1_Click() 'this is in userform2    EditMP 'this code is in userform2 and calls fine
    loadresults 'this code is in userform1 and gives me an error.
End Sub

Só I remembered that I used this mechanism when the code was on a module, therefore I removed the "loadresults" from userform1 and pasted it in module 1 and declared it public. Like so:

Public Sub loadresults()  'simply reload results, saved on a module not a userform.
UserForm1.TextBox1 = Format(ThisWorkbook.Sheets("LD").Range("W28"), "Standard") 'Custo para Lingotamento
UserForm1.TextBox2 = Format(ThisWorkbook.Sheets("LD").Range("P412"), "Standard") 'Balanço térmico
UserForm1.TextBox3 = Format(ThisWorkbook.Sheets("LD").Range("J15"), "Standard") '% ressopro P
UserForm1.TextBox4 = Format(ThisWorkbook.Sheets("LD").Range("J18"), "Standard") 'indice de projeçao
UserForm1.TextBox5 = Format(ThisWorkbook.Sheets("LD").Range("I22"), "Standard") 'rendimento Fe do Conversor Prelimiar
UserForm1.TextBox6 = Format(ThisWorkbook.Sheets("LD").Range("J22"), "Standard") 'rendimento Fe do Conversor Real
End Sub

It now works...
I would like to know why is it that I can't have a Public sub inside the userform folder?

Thanks for your time.

 

[Norie]

Not sure why you have the code in the userform module but have you tried calling it like this.

UserForm1.loadresults

 

[finaljustice]

Not sure why you have the code in the userform module but have you tried calling it like this.

UserForm1.loadresults

Cool that works! Basically you are informing where the code is correct?

Do you think it is good practice to put all the code inside a modules instead of userform modules?

Thanks for your attention!

 

[Norie]

It really depends what you are trying to do.

In this case I might put the code in UserForm2's module, either within the button's click event or as a separate sub.