Problem saving VBScript Script Files

[pupsia]

Hello all,

I'm used to Macro program writing but I'm new to VBScript Script Files and I cant seem to find what can be wrong no matter where I look.
I have a problem with running this vbs file, getting this error:

Line: 7
Char: 1
Error: "Object required: 'application'
Code: 800A01A8

Dim xlApp
Dim xWb


Set xlApp = CreateObject("Excel.Application") 
Set xWb = xlApp.Workbooks


For each xWb in application.Workbooks
	If not xWb.readonly and windows(xWb.name).visible then
		xWb.save
	End if
Next

Any ideas why this could be?

Thank you!

 

[RoryA]

Use xlApp instead of application.

 

[pupsia]

Right now there are no errors like before, but when i run the program, the [Saved] does not appear like usual when you save an excel file, so it doesn't save for some reason

 

[RoryA]

What do you mean by that? What [Saved]?

 

[pupsia]

The program should go through all open Excel files and if there are any that are not Read Only, save those files.

What I meant by [Saved] is when we have a name at the top green filed in Excel, how that name changed after a save was done.

Original name (in green field) example:
abc.xlsx - Excel

After you click save:
abc.xlsx - Saved

Now there are no errors as before, but the Excel I have opened for testing is not being saved.

 

[RoryA]

You're creating a new Excel application instance and looping through that, so there won't be any workbooks to save.

 

[pupsia]

Oh, so that does not capture old already opened workbooks. I guess it makes sense that it didn't work as I wanted.

Any advise how I could go through all already opened Excel files and save them?
As I don't know what files will be open and from what path, I cant use direct names for that.
Sometimes there could be 10 or 40 Excel opened at a time..

 

[RoryA]

If you only have one Excel application instance open, you can just use GetObject rather than CreateObject.

 

[pupsia]

Thank you for the tip!

I didn't think about using get instead of create, totally new to this type or writing...

After testing a few things out, this seems to work and does save the files if i run the program:

set objExcel = getobject(,"Excel.Application")

For Each aWorkbook In objExcel.Workbooks
    If aWorkbook.Saved = False Then
       aWorkbook.Save
    End If
Next

Though I couldn't find a working way to add the "Read Only" and "Visible" parts I had before