Problem saving a sheet named as a cell value

Peolini

New Member
Joined
Jan 30, 2025
Messages
7
Office Version
  1. 365
Platform
  1. Windows
Hello all,
I would like to have a button on a form which will save the sheet named as the value of a cell..
The button is not a problem, assigning a macro to it neither,

But when I run this macro

Sub SaveFileWithCellValue()
Dim FileName As String
Dim FilePath As String

FileName = Sheets("Eindtest").Range("D2").Value

FilePath = "G:\P1-P3\Dennis\EindtestForms" & FileName & ".xlsm"

ActiveWorkbook.SaveAs FileName:=FileName, FileFormat:=xlOpenXMLWorkbook

End Sub

I get the following message:

1738251023399.png


Where do I go wrong?

The form/sheet is already in .xlsm format and the target folder also already contains other .xlsm files.


Thank you.
 

Excel Facts

Easy bullets in Excel
If you have a numeric keypad, press Alt+7 on numeric keypad to type a bullet in Excel.
Hello all,
I would like to have a button on a form which will save the sheet named as the value of a cell..
The button is not a problem, assigning a macro to it neither,

But when I run this macro

Sub SaveFileWithCellValue()
Dim FileName As String
Dim FilePath As String

FileName = Sheets("Eindtest").Range("D2").Value

FilePath = "G:\P1-P3\Dennis\EindtestForms" & FileName & ".xlsm"

ActiveWorkbook.SaveAs FileName:=FileName, FileFormat:=xlOpenXMLWorkbook

End Sub

I get the following message:

View attachment 121827

Where do I go wrong?

The form/sheet is already in .xlsm format and the target folder also already contains other .xlsm files.


Thank you.
Cannot save a workbook with macros to a normal xlsx file as indicated by the Fileformat:=XLOpenXMLWorkBook in your example line of code.
 
Upvote 0
Oh yes, you need to put "\" between the folder name and the file name. Like so
FilePath = "G:\P1-P3\Dennis\EindtestForms\" & FileName & ".xlsm"
Also, what is the value of range D2 ?
 
Upvote 0
Oh yes, you need to put "\" between the folder name and the file name. Like so
FilePath = "G:\P1-P3\Dennis\EindtestForms\" & FileName & ".xlsm"
Also, what is the value of range D2 ?
Unfortunately still the same message. Debugging shows the last line in yellow..
1738252576972.png


D2 is a simple number like "M24215569"
 
Upvote 0
Well, are you not supposed to use variable FilePath as argument for saveAs ? Because you use fileName in your screenshot.
VBA Code:
ActiveWorkbook.SaveAs FileName:=FilePath, FileFormat:=xlOpenXMLWorkbookMacroEnabled
But if this still does not work, the value of your cell is invalid. It is what the error message is saying very clearly. Try to print it to see what comes out.
 
Upvote 0
Solution
Well, are you not supposed to use variable FilePath as argument for saveAs ? Because you use fileName in your screenshot.
VBA Code:
ActiveWorkbook.SaveAs FileName:=FilePath, FileFormat:=xlOpenXMLWorkbookMacroEnabled
But if this still does not work, the value of your cell is invalid. It is what the error message is saying very clearly. Try to print it to see what comes out.
Thank you.
I have changed the cell format from D2 from "general" to "text" and that worked better. no messages.
But also no saved files in the specified folder....
 
Upvote 0
Did you try changing FileName to FilePath as @saboh12617 advised? Changing the format of the cell makes no difference btw

Rich (BB code):
ActiveWorkbook.SaveAs FileName:=FilePath, FileFormat:=xlOpenXMLWorkbookMacroEnabled
 
Upvote 0

Forum statistics

Threads
1,226,114
Messages
6,189,052
Members
453,522
Latest member
Seeker2025

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top