Private Sub Ucase Stopped working

[rickadams]

Hi,

For dyslexic people like me reading text that is mixed case is difficult so I found this script that was working great.
All of a sudden the script saved in my sheet(s) stopped working, on my main computer. When running on other computers the script still works.
I received an error after deleting some cells.
I closed and restarted Excel 2010 and now it will not work at all.
I do not think I changed any settings, however if I did which one would stop Private from Working?

Private Sub Worksheet_Change(ByVal Target As Range)
Application.EnableEvents = False
Target.Value = UCase(Target.Value)
Application.EnableEvents = True
End Sub

 

[RoryA]

Are you sure you completely restarted Excel and didn't just reopen the workbook?

 

[Peter_SSs]

I received an error after deleting some cells.

That will continue to happen if you delete multiple cells at once or paste multiple cells at once. I would suggest the following change to avoid that

Private Sub Worksheet_Change(ByVal Target As Range)
  Dim c As Range
  
  Application.EnableEvents = False
  For Each c In Target
    c.Value = UCase(c.Value)
  Next c
  Application.EnableEvents = True
End Sub

 

[rickadams]

Yes Peter that worked! Thank you so much!

 

[Peter_SSs]

Yes Peter that worked! Thank you so much!

Cheers.

 

[rickadams]

Thank you for responding, I shut down the computer (windows did its usual update thing) and the script still did not work. Peter_SS posted a solution, and that worked for me. This only happened on 1 computer. And I think I am good now...

 

[Peter_SSs]

Thank you for responding, I shut down the computer (windows did its usual update thing) and the script still did not work. Peter_SS posted a solution, and that worked for me. This only happened on 1 computer. And I think I am good now...

My suggestion was not related to your code "not working at all". The code could have "stopped working at all" when you got the error message deleting multiple cells because 'events' may have been left disabled. The suggestion of Rory's was one way to get your events re-enabled. Anyway, it seems like you have got to that point somehow.