Passing parameters in a class

[tiredofit]

Is it better to use properties to pass parameters in a class, (as in Method 1 below) or not?


Method 1:

Sheet1:

Private Sub UpdateTable()
    
    Dim MyUpdateTable As ClsUpdateTable
    
    Set MyUpdateTable = New ClsUpdateTable
    
    Set MyUpdateTable.Period = Me.Range("Now")
    
    Call MyUpdateTable.UpdateTable
    
End Sub

ClsUpdateTable

Option Explicit

    Private pPeriod As Range
    
Public Property Get Period() As Range
    
    Set Period = pPeriod
    
End Property

Public Property Set Period(ByVal P As Range)
    
    Set pPeriod = P
    
End Property

Sub UpdateTables()

    Dim MyArray() As Variant
            
    MyArray = Array("1", "2", "3")
    
    Dim MyArrayElement As Variant
    
    For Each MyArrayElement In MyArray()
    
        Range(Period.Address).Value = MyArrayElement
                    
    Next MyArrayElement         

End Sub

Method 2:

Sheet1:

Private Sub UpdateTable()
    
    Dim MyUpdateTable As ClsUpdateTable
    
    Set MyUpdateTable = New ClsUpdateTable
    
    Call MyUpdateTable.UpdateTable(Period:=Me.Range("Now"))
    
End Sub

ClsUpdateTable

Option Explicit

Sub UpdateTables(ByRef Period As Range)

    Dim MyArray() As Variant
            
    MyArray = Array("1", "2", "3")
    
    Dim MyArrayElement As Variant
    
    For Each MyArrayElement In MyArray()
    
        Range(Period.Address).Value = MyArrayElement
                    
    Next MyArrayElement         

End Sub

Thanks

 

[RoryA]

Define "better".

 

[Jaafar Tribak]

I am not sure if there is much difference but I personally prefer to pass all the parameters in a single Method or Property like in Method 2 specially when the number of parameters is relatively small or/and when there are optional arguments ... It involves less code and more readable.

 

[tiredofit]

Define "better".

I can't!

I am not sure if there is much difference but I personally prefer to pass all the parameters in a single Method or Property like in Method 2 specially when the number of parameters is relatively small or/and when there are optional arguments ... It involves less code and more readable.

When I was creating this, it occurred to me that IF I used method 1, there's never a need to write code such as (in a class):

Sub UpdateTables(ByRef Period As Range)

as in Method 2, ie to have to take in arguments because that's the purpose of using properties Get, Let and Set.

 

[Kyle123]

VBA lacks constructors which make it neater, but I do it by state/scope. If the property alters the state or is used outside the scope of a function/sub then I use a property, otherwise it's an argument.

 

[RoryA]

Unless you use those variables for anything else in the class, I don't really see any benefit of making them separate properties, unless perhaps you need to perform some validation on them.

 

[tiredofit]

Thanks