Passing Boolean result from one function to another

[Radoslaw Poprawski]

Hi All, i have a small code:

        xRet = IsWorkBookOpen(WBName)
        Call DeleteFiles(WBName, xRet)

Function IsWorkBookOpen(Name As String) As Boolean
    Dim xWb As Workbook
    On Error Resume Next
    Set xWb = Application.Workbooks.Item(Name)
    IsWorkBookOpen = (Not xWb Is Nothing)
End Function

Sub DeleteFiles(WBName As String, xRet As Boolean)
        With New FileSystemObject
            If xRet Then Workbooks(WBName).Close
            If .FileExists(Path & WBName) Then
                .DeleteFile Path & WBName
            End If
        End With
End Sub

My issue is when I try running the first 2 lines i get an error:

since xRet is boolean in result, then why cant I simply pass it to another function as boolean?

 

[dmt32]

Hi,
If you do not need to pass your arguments ByRef then pass them ByVal & see if this resolves your issue

Sub DeleteFiles(ByVal WBName As String, ByVal xRet As Boolean)
        With New FileSystemObject
            If xRet Then Workbooks(WBName).Close
            If .FileExists(Path & WBName) Then
                .DeleteFile Path & WBName
            End If
        End With
End Sub

Function IsWorkBookOpen(ByVal WBName As String) As Boolean
    Dim xWb As Workbook
    On Error Resume Next
    Set xWb = Application.Workbooks.Item(WBName)
    IsWorkBookOpen = (Not xWb Is Nothing)
End Function

Dave

 

[RoryA]

Or just declare xRet as Boolean. I suspect you either haven't declared it at all, or you declared it as Variant.