My PDFs dont save properly because of my code, don't know how to fix it

[Erik968]

This code is supposed to save the file as PDF to my pc and after that mail the XLSM and PDF file as attachments in an automated mail... but my pdf's dont get saved properly because my code is wrong and I just dont know how to fix it, does anyone know how I can fix it?

Sub saveandsend()


Dim Path As String
Dim filename As String
Path = "C:\Users\Erik Stoeken\Documents\van Wijk\Excel test\"
filename = Range("P39")
ActiveWorkbook.SaveAs filename:=Path & filename & ".xlsm"


' SendEmail Macro
'


Dim outlookapp As Object
Dim OutlookMail As Object
Set outlookapp = CreateObject("Outlook.Application")
Set OutlookMail = outlookapp.CreateItem(0)
On Error Resume Next
With OutlookMail
    .To = "erikstoeken@gmail.com"
    .CC = ""
    .BCC = ""
    .Subject = Range("X22")
    .Body = "Bon zit in de bijlage."
    .Attachments.Add Application.ActiveWorkbook.FullName
    .Attachments.Add (Path & filename & ".PDF")
    .Display
End With
Set OutlookMail = Nothing
Set outlookapp = Nothing




End Sub

 

[Eric Golf]

Re: My PDF's dont save properly because of my code, dont know how to fix it.. (read description)

Hi,

I don't see anywhere in your code that you are saving a file as type PDF?

Also it best to avoid using keywords as variable names e.g. "filename:=Path & filename & ".xlsm""

Hope this helps,

Eric

 

[Erik968]

Re: My PDF's dont save properly because of my code, dont know how to fix it.. (read description)

This is basically the biggest problem im having, I dont know much about VBA and was just watching some tutorials and now im stuck with this, all I know is that it is definitely saving files to my pc but they arent files what I can open... I just dont know what I need to add to get PDFs...

thanks for the reply.

 

[Eric Golf]

Re: My PDF's dont save properly because of my code, dont know how to fix it.. (read description)

Hi,

I see you have an answer in your other thread...

https://www.mrexcel.com/forum/excel...ment-doesnt-work-open.html?highlight=save+pdf

Please don't post the same question in multiple threads.

Eric