modifying code to get last value based on sheet name from file to another

[Mussala]

I need to adapt this code by add sheet name in D4 . the stock file will be many sheets and the last value will be in column H for all of sheets. if I write the sheet name in D4 then should get last value from column H based on matching with sheet name.

Sub populate_last_value()
  Dim wb1 As Workbook, wb2 As Workbook
  Dim sPath As String
  
  sPath = "D:\Users\MUSSS\Desktop\REPORT\"
  
  Set wb1 = Workbooks.Open(sPath & "OUTPUT.xlsm")
  Set wb2 = Workbooks.Open(sPath & "STOCK.xlsm")
  
  wb1.Sheets("SUMMARY").Range("B4").Value = wb2.Sheets("SH").Range("H" & Rows.Count).End(3).Value

  wb2.Close TRUE
End Sub

thanks

 

[mumps]

Copy and paste this macro into the worksheet code module. Do the following: right click the tab name for your sheet where you will enter the sheet name in D4 and click 'View Code'. Paste the macro into the empty code window that opens up. Close the code window to return to your sheet. Enter the sheet name in D4 and press the RETURN key.

Private Sub Worksheet_Change(ByVal Target As Range)
    If Target.CountLarge > 1 Then Exit Sub
    If Intersect(Target, Range("D4")) Is Nothing Then Exit Sub
    Application.ScreenUpdating = False
    Dim wb1 As Workbook, wb2 As Workbook, sPath As String
    sPath = "D:\Users\MUSSS\Desktop\REPORT\"
    Set wb1 = Workbooks.Open(sPath & "OUTPUT.xlsm")
    Set wb2 = Workbooks.Open(sPath & "STOCK.xlsm")
    wb1.Sheets("SUMMARY").Range("B4").Value = wb2.Sheets(Target.Value).Range("H" & Rows.Count).End(3).Value
    wb2.Close True
    Application.ScreenUpdating = True
End Sub

 

[Mussala]

Hello,

Copy and paste this macro into the worksheet code module.

can you do in standard module ,please?
also I want fixing error subscript out of range if the D4 is empty
thanks

 

[mumps]

Try:

Sub CopyValue()
    Application.ScreenUpdating = False
    Dim WB As Workbook, wb1 As Workbook, wb2 As Workbook, sPath As String
    sPath = "D:\Users\MUSSS\Desktop\REPORT\"
    Set WB = ThisWorkbook
    Set wb1 = Workbooks.Open(sPath & "OUTPUT.xlsm")
    Set wb2 = Workbooks.Open(sPath & "STOCK.xlsm")
    wb1.Sheets("SUMMARY").Range("B4").Value = wb2.Sheets(WB.Range("D4").Value).Range("H" & Rows.Count).End(3).Value
    wb2.Close True
    Application.ScreenUpdating = True
End Sub

 

[Mussala]

thanks again
but why the STOCK file keeps open !

 

[mumps]

but why the STOCK file keeps open !

This line of code closes the file so I'm not sure why it stays open.

wb2.Close True

 

[Mussala]

This line of code closes the file so I'm not sure why it stays open.

wb2.Close True

this reason makes me I surprised despite of you indicate the line should close , it's really strange !
any way thank you so much for your help .

 

[mumps]

You are very welcome.