message box show twice before is gone , why?!

[abdo meghari]

Hello
I need help to fix my problem .
when write in textbox2 and the optionbutton1,2 are not selected then should show message and clear textbox2 , but it will show the message twice before clear textbox2 !

Private Sub TextBox2_Change()
If Not (OptionButton1.Value) * (OptionButton2.Value) Then
MsgBox "please select one button at least": TextBox2.Value = ""
Exit Sub
Else
Call FilterData
End If

End Sub

thanks in advanced

 

[Skyybot]

Because, after the MessageBox shows you change TextBox2.Value which calls the TextBox2_Change again before the Sub ends the fist time.

 

[Rick Rothstein]

Try adding the two lines I show (one at the beginning and one at the end) and see if that solves your problem...

Private Sub TextBox2_Change()

  Application.EnableEvents = False
 
  If Not (OptionButton1.Value) * (OptionButton2.Value) Then
    MsgBox "please select one button at least": TextBox2.Value = ""
    Exit Sub
  Else
    Call FilterData
  End If
 
  Application.EnableEvents = True

End Sub

 

[Domenic]

As @Skyybot has already mentioned, changing the value for TextBox2.value triggers the change event again. And, unfortunately, setting EnableEvents to False won't disable events within a userform. However, you can use a module-level variable to help you avoid triggering the code again when the textbox value is changed. By the way, the following line of code will always evaluate to true...

If Not (OptionButton1.Value) * (OptionButton2.Value) Then

So maybe try something like this...

Option Explicit

Dim m_locked As Boolean

Private Sub TextBox2_Change()

    If m_locked = True Then Exit Sub

    If OptionButton1.Value = False And OptionButton2.Value = False Then
        m_locked = True
        MsgBox "please select one button at least": TextBox2.Value = ""
        m_locked = False
        Exit Sub
    Else
        Call FilterData
    End If

End Sub

Private Sub UserForm_Initialize()

    m_locked = False
  
End Sub

Hope this helps!

 

[abdo meghari]

@Rick Rothstein
thanks , but unfortunately still the same result .

 

[abdo meghari]

@Domenic
perfect !
thank you so much