Match VBa error

[mahmed1]

Hi all

I have been having issues with my match function if there isnt a match found. I had initially had worksheetfunction.match but read that i need to change to application.match but im still getting a type mismatch error - where am i going wrong?

MatchHeaders = Application.Match(QuestionRange.Cells(rr, cc).Value, ws.Range(ws.Cells(2, 1), ws.Cells(2, Lcol)), 0)
                        
                        If IsError(MatchHeaders) Then
                            Outputsh.Cells(OutputLR, 12).Value = 1
Outputsh.Cells(OutputLR, 15).Value = "Question not found"
                        Elseif not isnumber(ws.Cells(i, MatchHeaders))
                           Outputsh.Cells(OutputLR, 12).Value = 1
Outputsh.Cells(OutputLR, 15).Value = "Not a valid entry"
else
  Outputsh.Cells(OutputLR, 12).Value = ws.Cells(i, MatchHeaders)                      
End If

 

[JoeMo]

How did you declare the variable MatchHeaders? If you declare it as a Long or an Integer, then you will get a mismatch error if no match is found because Application.Match will return an error, not a long or integer. Declare it as a Variant or add an error trap.

 

[mahmed1]

Hiya

i declared it as long as normally that cell should have a number so im guessing trapping the error would be alternative which i thought i tried with iserror function

if there isnt a match then display a 1 in the cell and display “question not found” in column 15
if there is a match but the cell doesn’t contain a number (blank, text, rrror) etc then display 1 and in column 15 display “Not a valid entry”
else display the number as normal

this is what i tried doing with the example i showed with the match function

thank you once again

 

[JoeMo]

isError doesn't trap the error. Easier to declare the variable as a Variant.

 

[mahmed1]

Will do that thanks