macros to insert picture in active cell, but picture appears more shifted out of position the higher the row

[needhelp9009]

I am using a macros to insert pictures into the active cell.
i.e. click B3, run macros and choose picture from the file. this works well in row 3. However, as I continue adding pictures going down the rows. example B90, the picture appears shifted out of the box..

This is my code:

Sub test()
Dim myPic As String, Pic As Shape, Rng As Range
Dim a As Double, shp As Shape, x As Long, j As Long, jj As Long


    For Each shp In ActiveSheet.Shapes
        If Left(shp.Name, 7) = "Picture" Then x = x + 1
    Next shp
   
myPic = Application.GetOpenFilename( _
    FileFilter:="Images (*.jpg;*.gif;*.png),*.jpg;*.gif;*.png", _
        Title:="Please select an image...")
    If myPic = "False" Then Exit Sub

Set Pic = Application.ActiveSheet.Shapes.AddPicture(myPic, False, True, 0, 0, -1, -1)

j = ActiveCell.Row
jj = ActiveCell.Column


With Pic
    .Name = "Picture" & x + 1
    .LockAspectRatio = False
    .Left = Cells(j, jj).Left
    .Top = Cells(j, jj).Top - (j * 1 / 100)
    .Height = ActiveCell.Height
    .Width = ActiveCell.Width
   
End With

End Sub

 

[jolivanes]

You should use code tags and mention that you have the same question on another forum.

 

[needhelp9009]

You should use code tags and mention that you have the same question on another forum.

how to do code tags? as this computer is not mine i cannot download the XL2BB.
for referring to another forum, do i put the whole link into my question?
Thanks for helping to point this out. I am still new with the excel forum.

 

[jolivanes]

The same way as you did on the other site. Highlight your code and click on the sign as below.

Copy the path to your thread and paste it here.

 

[needhelp9009]

how to edit the thread? or do i have to redo? So i report myself to remove this post and redo?

 

[Fluff]

Welcome to the MrExcel Message Board!

Cross-posting (posting the same question in more than one forum) is not against our rules, but the method of doing so is covered by #13 of the Forum Rules.

Be sure to follow & read the link at the end of the rule too!

If you have posted the question on any other sites, please supply links to those posts.

If you do cross-post in the future and also provide links, then there shouldn’t be a problem.

 

[needhelp9009]

Hi Fluff, I would like to correct my mistake and add in the link to my question in the other forum. i do not see any edit button. if there is a need to delete and re-ask the question. please can you help me delete and i will redo my question.

 

[Fluff]

You just need to reply to the thread & include the link in that reply.

 

[needhelp9009]

I am using a macros to insert pictures into the active cell.
i.e. click B3, run macros and choose picture from the file. this works well in row 3. However, as I continue adding pictures going down the rows. example B90, the picture appears shifted out of the box..
View attachment 35638View attachment 35639

This is my code:

Sub test()
Dim myPic As String, Pic As Shape, Rng As Range
Dim a As Double, shp As Shape, x As Long, j As Long, jj As Long


    For Each shp In ActiveSheet.Shapes
        If Left(shp.Name, 7) = "Picture" Then x = x + 1
    Next shp
  
myPic = Application.GetOpenFilename( _
    FileFilter:="Images (*.jpg;*.gif;*.png),*.jpg;*.gif;*.png", _
        Title:="Please select an image...")
    If myPic = "False" Then Exit Sub

Set Pic = Application.ActiveSheet.Shapes.AddPicture(myPic, False, True, 0, 0, -1, -1)

j = ActiveCell.Row
jj = ActiveCell.Column


With Pic
    .Name = "Picture" & x + 1
    .LockAspectRatio = False
    .Left = Cells(j, jj).Left
    .Top = Cells(j, jj).Top - (j * 1 / 100)
    .Height = ActiveCell.Height
    .Width = ActiveCell.Width
  
End With

End Sub

to insert picture and cropped to fit in the boxes

I am trying to insert pictures on active cells to create a picture report. however, as I go down the activesheet,i.e. row number increase, the picture keeps moving lower from the active cell I am trying to add the picture in. it doesn't also fit nicely in the boxes. In the picture report, I...

www.excelforum.com

- this is the link to the same question i asked in another forum.

 

[jolivanes]

Were the pictures that you insert rotated and saved? (Right click on Picture, select "Size and Properties" and "Rotation")