Macro to copy values from multiple sheets in a workbook to a new worksheet in the same workbook

jmk15315

Board Regular
Joined
Nov 7, 2021
Messages
73
Office Version
  1. 2013
  2. 2010
Platform
  1. Windows
Rookie here and hoping someone can help me out.
I have a worksheet in which I want to compile information from multiple sheets into a single sheet and organize them by category. What I have done is create the following code, but it does not work.

Sub CopyValues()
Dim wsRobot As Worksheet
Dim wsPlatform As Worksheet
Dim wsControls As Worksheet
Dim wsJIF_DETAILS As Worksheet
Dim lastRow As Long
Dim i As Long
Dim j As Long

Set wsRobot = ThisWorkbook.Worksheets("Robot")
Set wsPlatform = ThisWorkbook.Worksheets("Platform")
Set wsControls = ThisWorkbook.Worksheets("Controls")
Set wsJIF_DETAILS = ThisWorkbook.Worksheets("JIF_DETAILS")

' Find the last row in column A of each worksheet
lastRow = wsRobot.Cells(wsRobot.Rows.Count, "A").End(xlUp).Row

' Loop through each row in column J of each worksheet
For i = 1 To lastRow
If wsRobot.Cells(i, "J").Value = "FG0100" and wsRobot.cells(i, "B").value = "1" Then
' Find the next available row in column A of wsJIF_DETAILS
j = wsJIF_DETAILS.Cells(wsJIF_DETAILS.Rows.Count, "A").End(xlUp).Row + 1

' Copy the value from column A of wsRobot to wsJIF_DETAILS
wsRobot.Cells(i, "A").Copy wsJIF_DETAILS.Cells(j, "A") 'CODE FAILS AT THIS POINT
End If
Next i
VBA Code:
End Sub
 

Excel Facts

Links? Where??
If Excel says you have links but you can't find them, go to Formulas, Name Manager. Look for old links to dead workbooks & delete.
wsRobot.Cells(i, "A").Copy wsJIF_DETAILS.Cells(j, "A") 'CODE FAILS AT THIS POINT
In what way does that line fail?

I'd also remove the quotes around the "1"
Rich (BB code):
If wsRobot.Cells(i, "J").Value = "FG0100" and wsRobot.cells(i, "B").value = "1" Then
 
Upvote 0
Helps if I pay attention to the error. I had a locked worksheet, so between removing the "" from around the 1 and adding an unprotect worksheet line to the code, it resolved the issue. Now all I need to do is figure out how to do this for multiple worksheets and multiple variables "FG0100", "FG0200", etc... without having a million+ lines of code.
 
Upvote 0
Now all I need to do is figure out how to do this for multiple worksheets
Something like
Rich (BB code):
    'Set wsRobot = ThisWorkbook.Worksheets("Robot")

    For Each wsRobot In ActiveWorkbook.Worksheets
        If wsRobot.Name <> wsJIF_DETAILS.Name Then

            For i = 1 To lastRow

                If wsRobot.Cells(i, "J").Value = "FG0100" And wsRobot.Cells(i, "B").Value = "1" Then

                    ' Find the next available row in column A of wsJIF_DETAILS

                    j = wsJIF_DETAILS.Cells(wsJIF_DETAILS.Rows.Count, "A").End(xlUp).Row + 1



                    ' Copy the value from column A of wsRobot to wsJIF_DETAILS

                    wsRobot.Cells(i, "A").Copy wsJIF_DETAILS.Cells(j, "A") 'CODE FAILS AT THIS POINT

                End If

            Next i
        End If

    Next wsRobot

and look into using an array for the multiple variables (I think you mean strings rather than variables btw)
 
Upvote 0

Forum statistics

Threads
1,223,227
Messages
6,170,848
Members
452,361
Latest member
d3ad3y3

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top