Macro to apply row borders

aa2000

Board Regular
Joined
Aug 3, 2011
Messages
87
Hi guys

So I have a macro which imports a text file to excel. The text files are made up of individual tables that each end with the word "END"

What I am now trying to do is get another macro running that detects every instance of "END" and then puts a continuous border along the bottom of that entire row.

My current code is

Code:
Sub EndBorder()
Set Borderrange = Range("A3:AS1000")
For Each Cell In Borderrange
If Cell.Value = "END" Then Cell.Borders(xlEdgeBottom).LineStyle = xlContinuous
Next Cell

End Sub

However this code only puts the border under the cell actually containing "END". How can I amend this to select the whole row

Thanks
 

Excel Facts

Excel motto
Not everything I do at work revolves around Excel. Only the fun parts.
Code:
Sub EndBorder()
Set Borderrange = Range("A3:AS1000")
For Each c In Borderrange.cells
If c.Value = "END" Then c.entirerow.Borders(xlEdgeBottom).LineStyle = xlContinuous
Next c
End Sub
Best to avoid reserved words as variable names

HTH
 
Upvote 0
Thank you for the code, it worked!

Unfortunately the text files are created automatically by a measurement tool we use, and I have no control over how it displays the results.
 
Upvote 0
What reserved word was used? :confused:
is Cell not a reserved word?

Bad terminology in my case perhaps, but I still think it's better to avoid variable names that look like they might be part of the underlying language.
 
Upvote 0
Cell isn't a reserved word. Cells is.

I generally use c though as it saves on typing :)
 
Upvote 0
I'm assuming that the tables must have a varying number of columns since you are not just searching in a particular column. I also don't know how many tables there are likely to be but searching every cell seems to me to be an inefficient way to go.

Perhaps you could consider something like below. If there are, say, 50 tables this will only need to do 50 rather than 44,910 loops.

<font face=Courier New><br><SPAN style="color:#00007F">Sub</SPAN> EndBorder()<br>    <SPAN style="color:#00007F">Dim</SPAN> Borderrange <SPAN style="color:#00007F">As</SPAN> Range, Found <SPAN style="color:#00007F">As</SPAN> Range<br>    <SPAN style="color:#00007F">Dim</SPAN> firstaddr <SPAN style="color:#00007F">As</SPAN> <SPAN style="color:#00007F">String</SPAN><br>    <br>    <SPAN style="color:#00007F">Set</SPAN> Borderrange = Range("A3:AS1000")<br>    <SPAN style="color:#00007F">With</SPAN> Borderrange<br>        <SPAN style="color:#00007F">Set</SPAN> Found = .Find(What:="END", LookIn:=xlValues, _<br>            Lookat:=xlWhole, SearchFormat:=False)<br>        <SPAN style="color:#00007F">If</SPAN> <SPAN style="color:#00007F">Not</SPAN> Found <SPAN style="color:#00007F">Is</SPAN> <SPAN style="color:#00007F">Nothing</SPAN> <SPAN style="color:#00007F">Then</SPAN><br>            firstaddr = Found.Address<br>            <SPAN style="color:#00007F">Do</SPAN><br>                Found.EntireRow.Borders(xlEdgeBottom).LineStyle _<br>                    = xlContinuous<br>                <SPAN style="color:#00007F">Set</SPAN> Found = .FindNext(After:=Found)<br>            <SPAN style="color:#00007F">Loop</SPAN> <SPAN style="color:#00007F">Until</SPAN> Found.Address = firstaddr<br>        <SPAN style="color:#00007F">End</SPAN> <SPAN style="color:#00007F">If</SPAN><br>    <SPAN style="color:#00007F">End</SPAN> <SPAN style="color:#00007F">With</SPAN><br><SPAN style="color:#00007F">End</SPAN> <SPAN style="color:#00007F">Sub</SPAN><br></FONT>
 
Last edited:
Upvote 0

Forum statistics

Threads
1,223,228
Messages
6,170,871
Members
452,363
Latest member
merico17

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top