macro is skipping tabs

[jadams121]

good morning,

Newbie here...i have a macro for auto generating tabs into PDFs and save them. the issue i'm having is that it is randomly skipping over some of the tabs. anyone have an idea how to fix this?

I checked the ones that get skipped to see if cell "A5" is the problem but it is not, as it has the exact same cell value but chooses to generate randomly (although its consistently the same tabs, and never different ones)...i have no idea how else to audit this.

please help, and thank you in advance!

[TABLE="width: 493"]
<colgroup><col></colgroup><tbody>[TR]
[TD]Option Explicit[/TD]
[/TR]
[TR]
[TD][/TD]
[/TR]
[TR]
[TD][/TD]
[/TR]
[TR]
[TD]'-------------------------------------------------------------------------------[/TD]
[/TR]
[TR]
[TD]Sub Save_as_Pdfs()[/TD]
[/TR]
[TR]
[TD]'-------------------------------------------------------------------------------[/TD]
[/TR]
[TR]
[TD]' Saves marked sheets as PDF file.[/TD]
[/TR]
[TR]
[TD]Dim PDF_path As String[/TD]
[/TR]
[TR]
[TD]Dim Snr As Integer[/TD]
[/TR]
[TR]
[TD]Dim Name As String[/TD]
[/TR]
[TR]
[TD][/TD]
[/TR]
[TR]
[TD][/TD]
[/TR]
[TR]
[TD]PDF_path = "d:\PDF\"   'edit path as required[/TD]
[/TR]
[TR]
[TD][/TD]
[/TR]
[TR]
[TD][/TD]
[/TR]
[TR]
[TD]On Error Resume Next[/TD]
[/TR]
[TR]
[TD][/TD]
[/TR]
[TR]
[TD][/TD]
[/TR]
[TR]
[TD]'Process all sheets in workbook[/TD]
[/TR]
[TR]
[TD]For Snr = 1 To ActiveWorkbook.Sheets.Count[/TD]
[/TR]
[TR]
[TD]    Sheets(Snr).Activate[/TD]
[/TR]
[TR]
[TD]    'Only print if A5 contains "YES"[/TD]
[/TR]
[TR]
[TD]    If Cells(5, "A").Value = "YES" Then[/TD]
[/TR]
[TR]
[TD]        Name = PDF_path & ActiveSheet.Name & Cells(4, "B").Value & ".pdf"[/TD]
[/TR]
[TR]
[TD]        ActiveSheet.ExportAsFixedFormat Type:=xlTypePDF, Filename:=Name, _[/TD]
[/TR]
[TR]
[TD]        Quality:=xlQualityStandard, IncludeDocProperties:=False, _[/TD]
[/TR]
[TR]
[TD]        IgnorePrintAreas:=False, OpenAfterPublish:=False[/TD]
[/TR]
[TR]
[TD]    End If[/TD]
[/TR]
[TR]
[TD]Next Snr[/TD]
[/TR]
[TR]
[TD]End Sub[/TD]
[/TR]
</tbody>[/TABLE]

 

[Fluff]

Remove this line & see what happens

On Error Resume Next

 

[JoeMo]

What happens if you change this line:

If Cells(5, "A").Value = "YES" Then

to this:

If Ucase(Trim(Cells(5, "A").Value)) = "YES" Then

 

[jadams121]

thanks for the help, but now i get a "run time error 1004" at the first tab that it starts skipping tabs

 

[jadams121]

thanks Joe...didn't change anything...still the same result

 

[Fluff]

What is the error message & which line of code is highlighted when you click debug?

 

[jadams121]

this entire area is highlighted:

ActiveSheet.ExportAsFixedFormat Type:=xlTypePDF, Filename:=Name, _
        Quality:=xlQualityStandard, IncludeDocProperties:=False, _
        IgnorePrintAreas:=False, OpenAfterPublish:=False

 

[Fluff]

And the error message?

Also what is the value of Cells(4,"B") on the sheet it fails on?

 

[jadams121]

runtime error 1004

"CONCRETE - PILE/COLUMN"

is it the backslash??

 

[Fluff]

1004 is the error number, not the error message

Yes the problem is the / as it is an illegal character for a filename