Macro assistance - inserting user name but cell not updating when workbook opened by another staff member

[Aussie5380]

Hi There,

I have been provided with the below macro, but im having a little trouble with the user name not updating when the workbook is opened by another staff member.

The code i have is below:

Public Function UserName()
Application.Volatile
UserName = Environ$("UserName")
End Function

I have tried to add the "Application.Volatile" bit, but it doesnt update the range of cells i need.

The cells where the user name is to generate is:

D11:F11 (merged cells)

The code in the cells is:

=VBAProject.WELCOME.UserName()

When someone else opens it, it has my name listed, where it should have the current users name (as its linked to checklist generators and saves the staff having to write their name)

Is anyone able to assist, im just not sure what else i can try?

Many thanks,

Shaun

 

[Micron]

Step through the code and check your results. Or add Debug.Print UserName before End Function. If you see nothing in the immediate window, that's your issue - the value isn't being over-written. Unfortunately I don't know how to code to write a value to a group of merged cells so maybe that's something to look at if you get a result in the immediate window. FWIW I would never name a procedure (or any object for that matter) using another function name (Environ) or any of its named variables (e.g. UserName).

 

[rlv01]

Instead of using a UDF, why not use the workbook open event to write the username to the cell you want?

Example (not tested)

Private Sub Workbook_Open()
    Me.Worksheets("Sheet1").Range("D11").Value = Environ$("UserName")
End Sub

(Tip: For future posts , you should try to use code tags like I did above when posting your code. It makes it easier to read.)

How to Post Your VBA Code

Post your VBA code.

www.mrexcel.com

 

[Aussie5380]

Instead of using a UDF, why not use the workbook open event to write the username to the cell you want?

Example (not tested)

Private Sub Workbook_Open()
    Me.Worksheets("Sheet1").Range("D11").Value = Environ$("UserName")
End Sub

(Tip: For future posts , you should try to use code tags like I did above when posting your code. It makes it easier to read.)

How to Post Your VBA Code

Post your VBA code.

www.mrexcel.com

Thank you, and apologies, i will use the code tag next time i have seen this code before, im just unsure where i pop this? Do i just add it to a new normal module?

One last question - the Sheet name, is that what i have actually named the sheet? (FRONT COVER) or is it the sheet number listed in the VBA writer (Sheet4)

once again, thank you for your assistance

 

[Aussie5380]

Step through the code and check your results. Or add Debug.Print UserName before End Function. If you see nothing in the immediate window, that's your issue - the value isn't being over-written. Unfortunately I don't know how to code to write a value to a group of merged cells so maybe that's something to look at if you get a result in the immediate window. FWIW I would never name a procedure (or any object for that matter) using another function name (Environ) or any of its named variables (e.g. UserName).

Thank you! adding the "Debug.Print UserName " has fixed it! You sir are a scholar and a gentleman!

Thanks everyone for your assistance. Its greatly appreciated!

 

[Micron]

The debug didn't really fix it, it could only reveal the cause? What was the cause - no value in variable UserName (and what did you do to fix it if that was the problem)?

 

[rlv01]

im just unsure where i pop this? Do i just add it to a new normal module?

It goes in the workbook code module

One last question - the Sheet name, is that what i have actually named the sheet? (FRONT COVER) or is it the sheet number listed in the VBA writer (Sheet4)

It's what you actually named the sheet (i.e "Sheet1","Main", "Data", etc.)

 

[Aussie5380]

The debug didn't really fix it, it could only reveal the cause? What was the cause - no value in variable UserName (and what did you do to fix it if that was the problem)?

Im not sure what has fixed it then. The code looks like this:

Public Function UserName()
Application.Volatile
UserName = Environ$("UserName")
Debug.Print UserName
End Function

(apologies, im not sure how to use the code tag?)

the cell calls this macro via this code:

=VBAproject.ADDNAME.UserName()

When another staff member opens it, it now shows their name! The only thing i can think of is there must have been something wrong with the module naming as thats the only other thing i have changed

 

[Micron]

You could rem out (comment out) the debug line as it's only for troubleshooting. It did nothing to fix your problem. It had to be something else.
BTW, I agree with setting the cell value in the open event as was suggested. That's probably where the solution credit should go.