Looping a MkDir function

[anichols]

Hello all,

I am trying to create a batch of folders where the code is normally quite simple:

MkDir[D3&E3]

I have several hundred that I regularly make. So far, I just have the same line repeated, but I'm trying to do some sort of loop or check to look for values in a column, and if present create the folder. So far I have tried several variations, and have been unsuccessful, so any help would be greatly appreciated. (My error hits at the "Then" portion as I try to add the Row value to the MkDir)

Sub CreateTheMonthlyFolders()
Dim Lastrow As Long: Dim Frow As Long
Sheets("FOLDERStest").Select

Lastrow = ActiveSheet.Range("B" & Rows.Count).End(xlUp).Row
    For Frow = 5 To Lastrow
        If Range("B" & Frow).Value <> "" Then MkDir [("D"&Frow)&("E"&Frow)]  'normally MkDir[D5&E5]
    Next Frow
End Sub

 

[Craggs82]

Your best bet is to combine the cell values into a string and pass that to the MkDir function. i've trimmed out the select and added a reference to the worksheet so we're always looking in the right place.

Option Explicit

Sub CreateTheMonthlyFolders()

    Dim Lastrow As Long
    Dim fRow As Long
    Dim ws As Worksheet
    Dim fPath As String
    
    Set ws = ThisWorkbook.Sheets("FOLDERStest")

    With ws
        Lastrow = .Range("B" & Rows.Count).End(xlUp).Row
        
        For fRow = 5 To Lastrow
            
            If .Range("B" & fRow).Value <> "" Then
                fPath = .Range("E" & fRow) & .Range("F" & fRow)
                MkDir fPath
            End If
        Next fRow
    End With
    
End Sub

 

[anichols]

Your best bet is to combine the cell values into a string and pass that to the MkDir function. i've trimmed out the select and added a reference to the worksheet so we're always looking in the right place.

Option Explicit

Sub CreateTheMonthlyFolders()

    Dim Lastrow As Long
    Dim fRow As Long
    Dim ws As Worksheet
    Dim fPath As String
   
    Set ws = ThisWorkbook.Sheets("FOLDERStest")

    With ws
        Lastrow = .Range("B" & Rows.Count).End(xlUp).Row
       
        For fRow = 5 To Lastrow
           
            If .Range("B" & fRow).Value <> "" Then
                fPath = .Range("E" & fRow) & .Range("F" & fRow)
                MkDir fPath
            End If
        Next fRow
    End With
   
End Sub

That worked perfectly, thank you!