Loading xml data into excel

Azhar0554

New Member
Joined
Oct 16, 2017
Messages
10
Hi

We will get 200+ xml and each will include 100+ item details so in total 20000+ item details needs to be loaded into excel. the below code take more than an hour and the excel went to not responding.

Can anyone help me to improve this.

For sheet_x = 1 To main_loop ' Loop for multiple xml files
Sheet8.Cells(sheet_x, 2) = Path & "" & Sheet8.Cells(sheet_x, 1)
Filename = Sheet8.Cells(sheet_x, 2)


Set XMLDoc = CreateObject("Microsoft.XMLDOM")
XMLDoc.async = "false"


'Loading individual files into XMLDOC


XMLDoc.Load (Filename)
XMLDoc.setProperty "SelectionLanguage", "XPath"
XMLDoc.setProperty "SelectionNamespaces", "Companies namespace'"








Set objNodeList1 = XMLDoc.SelectNodes("/ns0:ItemMaintenance/ns0:Item")
length1 = objNodeList1.Length 'length1 is for number of items




Dim obj1, obj2 As String
Dim ItemID, DepartmentId, ItemPrice, ProductId, PLU As String




For i = 1 To length1 ' Till all items in the file


ItemID = "/ns0:ItemMaintenance/ns0:Item" & "[" & & "]" & "/arts:ItemID"

DepartmentId = "//ns0:Item" & "[" & & "]" & "/arts:MerchandiseHierarchy [@Level='Department']/@ID"
ItemPrice = "/ns0:ItemMaintenance/ns0:Item" & "[" & & "]" & "/ns0:ItemPrice"
ProductId = "//ns0:ItemMaintenance/ns0:Item" & "[" & & "]" & "/ns0:AlternativeItemID [@Name='ProductID']"
PLU = "//ns0:Item" & "[" & & "]" & "/ns0:AlternativeItemID [@Name='POSItemID']"


Set ItemIDObj = XMLDoc.SelectNodes(ItemID)
Set DepartmentIdObj = XMLDoc.SelectNodes(DepartmentId)
Set ItemPriceObj = XMLDoc.SelectNodes(ItemPrice)
Set ProductIdObj = XMLDoc.SelectNodes(ProductId)
Set PLUObj = XMLDoc.SelectNodes(PLU)

j = 0

Sheet6.Cells(l1, 4) = DepartmentIdObj(j).Text
Sheet6.Cells(l1, 8) = ItemPriceObj(j).Text
Sheet6.Cells(l1, 6) = ItemIDObj(j).Text
Sheet6.Cells(l1, 5) = ProductIdObj(j).Text
Sheet6.Cells(l1, 7) = PLUObj(j).Text
l1 = l1 + 1

Next
l1 = l1
Next

Thanks in advance
Azhar
 

Excel Facts

What is the fastest way to copy a formula?
If A2:A50000 contain data. Enter a formula in B2. Select B2. Double-click the Fill Handle and Excel will shoot the formula down to B50000.

Forum statistics

Threads
1,223,908
Messages
6,175,307
Members
452,633
Latest member
DougMo

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top