Issues with code to prevent saving changes on close

[davidam]

Hello All,
Long ago, I copied the following code into the Workbook Objects.

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)
ActiveWorkbook.Saved = True
Cancel = True
End Sub

It has always worked fine, it seems. However, I sometimes have some kind of memory leak that occurs when I close other workbooks while this workbook is open. I wonder if anyone can comment
on the variables that are bracketed in the above code, which seem to have no purpose that I can find.
Thanks,
David

 

[mumps]

Maybe:

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)
    Dim WB As Workbook
    Set WB = ThisWorkbook
    WB.Saved = True
    Cancel = True
End Sub

 

[davidam]

Right. I think ThisWorkbook definitely makes more sense than ActiveWorkbook. I still don't understand the variables.

 

[mumps]

I suppose that you could shorten it to:

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)
    ThisWorkbook.Saved = True
    Cancel = True
End Sub

 

[davidam]

Agreed. Any thoughts on the bracketed variables? Like I said, I copied this code from another source and I really cannot understand what those variables are for.
P.S. I do think the change that you suggested could be a factor in the 'Out of Memory' issue.

 

[mumps]

Have a look at this link: Workbook.BeforeSave event (Excel)

 

[davidam]

Great. I guess my confusion arises from my understanding of passing variables from one sub to another. Am I correct to understand that in a worksheet event like this, I am supposed to address the variables within the event sub. In the case of the 'Cancel', I am setting it to 'True'. Would the following be correct if I wanted to prevent the UI display?

Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)
    ThisWorkbook.Saved = True
    SaveAsUI = False
    Cancel = True
End Sub

 

[mumps]

I believe so.

 

[davidam]

Thank you!

 

[mumps]

You are very welcome.