Invalid qualifier excel macro

[martinsk]

Hi everyone, Am having a litter trouble with Macro in excel. here is my code.

Sub sampleworksheet()</SPAN>
Dim cursheet As Worksheet</SPAN>
Dim j As Integer</SPAN>
Dim curname As String</SPAN>
Dim channame As String</SPAN>
Dim modifiedchanname As String</SPAN>

'itterate all worksheets in workbook</SPAN>
For j = 1 To ActiveWorkbook.Worksheets.Count</SPAN>
cursheet = ActiveWorkbook.Worksheets(j)</SPAN>
If Not IsEmpty(curname.Cells(1, 1)) Then</SPAN>
channame = cursheet.Cells(4, 2)</SPAN>
curname = cursheet.Name</SPAN>


modifiedchanname = channame</SPAN>

'channame must be valid excel worksheet name!!!!!!!!!!!!</SPAN>
cursheet.Name = modifiedchanname</SPAN>
End If</SPAN>
Next j</SPAN>
End Sub</SPAN>

I am getting "invalid qualifer" at curname (i have highlighted it in the code). I cant seem to get my head around.

Can anyone help please, i will be soo happy

 

[Jonmo1]

Welcome to the board.

It's hard to read your code like that, not sure how it ended up just written like a paragraph of text...

But I think the problem is This
cursheet = ActiveWorkbook.Worksheets(j)
should be
Set cursheet = ActiveWorkbook.Worksheets(j)

 

[Comfy]

Please use code tags when posting code.

curname should read cursheet.

Sub sampleworksheet()
Dim cursheet As Worksheet
Dim j As Integer
Dim curname As String
Dim channame As String
Dim modifiedchanname As String
'itterate all worksheets in workbook
For j = 1 To ActiveWorkbook.Worksheets.Count
cursheet = ActiveWorkbook.Worksheets(j)
If Not IsEmpty(cursheet.Cells(1, 1)) Then
channame = cursheet.Cells(4, 2)
curname = cursheet.Name
modifiedchanname = channame
'channame must be valid excel worksheet name!!!!!!!!!!!!
cursheet.Name = modifiedchanname
End If
Next j
End Sub

 

[Norie]

Try declaring curname as a Worksheet and add this as the first line in the loop.

Set curname = ActiveWorkbook.Worksheets(j)

 

[Norie]

Oops, misread code.

Try this.

Sub sampleworksheet()
Dim cursheet As Worksheet
Dim j As Integer
Dim channame As String
Dim curname As String
Dim modifiedchanname As String

    'itterate all worksheets in workbook
    For j = 1 To ActiveWorkbook.Worksheets.Count
    
        Set cursheet = ActiveWorkbook.Worksheets(j)
        
        If Not IsEmpty(cursheet.Cells(1, 1)) Then
            channame = cursheet.Cells(4, 2)
            curname = cursheet.Name
            modifiedchanname = channame
            'channame must be valid excel worksheet name!!!!!!!!!!!!
            cursheet.Name = modifiedchanname
        End If
        
    Next j
    
End Sub

 

[martinsk]

Thank you soo much guys, it worked .

Next time I will use code tags when posting a code. Again thank you guys