Image VBA

[Deelof]

I'm using the following VBA to add images into rows but they are not aligning, any ideas how to improve so they do?
URL's are held in column Z.

Sub URLPictureInsert()

    Dim Pshp As Shape
    Dim xRg As Range
    Dim xCol As Long
    On Error Resume Next
    Application.ScreenUpdating = False
    Set Rng = ActiveSheet.Range("Z4:Z219")
    For Each cell In Rng
        filenam = cell
        ActiveSheet.Pictures.Insert(filenam).Select
        Set Pshp = Selection.ShapeRange.Item(1)
        If Pshp Is Nothing Then GoTo lab
        xCol = cell.Column + 1
        Set xRg = Cells(cell.Row, xCol)
        With Pshp
            .LockAspectRatio = msoFalse
            .Width = 90
            .Height = 110
            .Top = xRg.Top + (xRg.Height - .Height) / 2
            .Left = xRg.Left + (xRg.Width - .Width) / 2
        End With
lab:
    Set Pshp = Nothing
    Range("A2").Select
    Next
    Application.ScreenUpdating = True
End Sub

 

[DanteAmor]

Check if the following works better for you.

Sub URLPictureInsert()
  Dim Pshp As Shape
  Dim xRg As Range, rng As Range, cell As Range
  Dim xCol As Long
  Dim filenam As String
  
  On Error Resume Next
  Application.ScreenUpdating = False
  Set rng = ActiveSheet.Range("Z4:Z219")
  For Each cell In rng
    filenam = cell
    If filenam <> "" And Dir(filenam) <> "" Then
      ActiveSheet.Pictures.Insert(filenam).Select
      Set Pshp = Selection.ShapeRange.Item(1)
      If Pshp Is Nothing Then GoTo lab
      xCol = cell.Column + 1
      Set xRg = Cells(cell.Row, xCol)
      With Pshp
        .LockAspectRatio = msoFalse
        .Width = xRg.Width - 2      '90
        .Height = xRg.Height - 2    '110
        .Top = xRg.Top + 1          '+ (xRg.Height - .Height) / 2
        .Left = xRg.Left + 1        '+ (xRg.Width - .Width) / 2
      End With
    End If
lab:
    Set Pshp = Nothing
    Range("A2").Select
  Next
  Application.ScreenUpdating = True
End Sub

 

[Deelof]

Check if the following works better for you.

Sub URLPictureInsert()
  Dim Pshp As Shape
  Dim xRg As Range, rng As Range, cell As Range
  Dim xCol As Long
  Dim filenam As String
 
  On Error Resume Next
  Application.ScreenUpdating = False
  Set rng = ActiveSheet.Range("Z4:Z219")
  For Each cell In rng
    filenam = cell
    If filenam <> "" And Dir(filenam) <> "" Then
      ActiveSheet.Pictures.Insert(filenam).Select
      Set Pshp = Selection.ShapeRange.Item(1)
      If Pshp Is Nothing Then GoTo lab
      xCol = cell.Column + 1
      Set xRg = Cells(cell.Row, xCol)
      With Pshp
        .LockAspectRatio = msoFalse
        .Width = xRg.Width - 2      '90
        .Height = xRg.Height - 2    '110
        .Top = xRg.Top + 1          '+ (xRg.Height - .Height) / 2
        .Left = xRg.Left + 1        '+ (xRg.Width - .Width) / 2
      End With
    End If
lab:
    Set Pshp = Nothing
    Range("A2").Select
  Next
  Application.ScreenUpdating = True
End Sub

Thanks but do I need to make any adjustments to the script as it's still not aligning the images?

 

[DanteAmor]

it's still not aligning the images

Align to what?

Could you post an image of how the images look after running the macro in post #2.

And another image of how you would like the result.


This is my example with 3 images, the 3 images are in column AA, inside the cell in each row and "aligned".

 

[Deelof]

Here's an example of how they're not aligning in the row

 

[DanteAmor]

Could you post an image of how the images look after running the macro in post #2.

Did you try the code from post #2?

 

[Deelof]

Did you try the code from post #2?

Could you resend as it looks to be the same as post #1

 

[DanteAmor]

Could you resend as it looks to be the same as post #1

It looks like the same code, but I already made changes so it really works well.
Just delete your macro and try the updated macro from post #2.

 

[DanteAmor]

You could at least give me the benefit of the doubt and test my macro.

However, I like to help , I put my macro back in.

Sub URLPictureInsert_V1()
  Dim Pshp As Shape
  Dim xRg As Range, rng As Range, cell As Range
  Dim xCol As Long
  Dim filenam As String
  
  On Error Resume Next
  Application.ScreenUpdating = False
  Set rng = ActiveSheet.Range("Z4:Z219")
  For Each cell In rng
    filenam = cell
    If filenam <> "" And Dir(filenam) <> "" Then
      ActiveSheet.Pictures.Insert(filenam).Select
      Set Pshp = Selection.ShapeRange.Item(1)
      If Pshp Is Nothing Then GoTo lab
      xCol = cell.Column + 1
      Set xRg = Cells(cell.Row, xCol)
      With Pshp
        .LockAspectRatio = msoFalse
        .Width = xRg.Width - 2
        .Height = xRg.Height - 2
        .Top = xRg.Top + 1
        .Left = xRg.Left + 1
      End With
    End If
lab:
    Set Pshp = Nothing
    Range("A2").Select
  Next
  Application.ScreenUpdating = True
End Sub

 

[Deelof]

You could at least give me the benefit of the doubt and test my macro.

However, I like to help , I put my macro back in.

Sub URLPictureInsert_V1()
  Dim Pshp As Shape
  Dim xRg As Range, rng As Range, cell As Range
  Dim xCol As Long
  Dim filenam As String
 
  On Error Resume Next
  Application.ScreenUpdating = False
  Set rng = ActiveSheet.Range("Z4:Z219")
  For Each cell In rng
    filenam = cell
    If filenam <> "" And Dir(filenam) <> "" Then
      ActiveSheet.Pictures.Insert(filenam).Select
      Set Pshp = Selection.ShapeRange.Item(1)
      If Pshp Is Nothing Then GoTo lab
      xCol = cell.Column + 1
      Set xRg = Cells(cell.Row, xCol)
      With Pshp
        .LockAspectRatio = msoFalse
        .Width = xRg.Width - 2
        .Height = xRg.Height - 2
        .Top = xRg.Top + 1
        .Left = xRg.Left + 1
      End With
    End If
lab:
    Set Pshp = Nothing
    Range("A2").Select
  Next
  Application.ScreenUpdating = True
End Sub

I do appreciate your assistance and I did try both and just tried the recent posted one again but the images are still not row aligning

These all need to shift down so they sit in 212 - 214 centrally