if then else

[montecarlo2012]

Hi, everyone.
I am trying to use if then else but results are wrong
on "B1" I just type "f" or "m" mean female or male and on c7 I want the constant divided by 2 for f, and by 3 for male, I tried this

Option Explicit
Sub test()
Dim f As String, m As String
Dim constant As Integer
Dim result As Integer
Dim gender As String
    gender = Range("b1").Value
    
    constant = 500
    f = Range("b1").Value
    m = Range("b1").Value

 If gender = f Then
    result = constant / 2
    Else
    m = constant / 3
    result = m
    
    End If
    
    Range("c7").Value = result
    
    
End Sub

 

[Arithos]

Your macro confuse me :P You are overthinking it.

Sub test()

If Range("b1").Value = "f" Then
        Range("c7").Value = 500 / 
End If
 If Range("B1").Value = "m" Then
        Range("c7").Value = 500 / 3
End If
End Sub

 

[Arithos]

Hi, everyone.
I am trying to use if then else but results are wrong
on "B1" I just type "f" or "m" mean female or male and on c7 I want the constant divided by 2 for f, and by 3 for male, I tried this

Option Explicit
Sub test()
Dim f As String, m As String
Dim constant As Integer
Dim result As Integer
Dim gender As String
    gender = Range("b1").Value
    
    constant = 500
    f = Range("b1").Value
    m = Range("b1").Value

 If gender = f Then
    result = constant / 2
    Else
    m = constant / 3
    result = m
    
    End If
    Range("c7").Value = result
End Sub

In your macro you wrote.

gender = Range("b1").Value

and then

f = Range("b1").Value

and THEN

 If gender = f Then

.... This will always be true.. so It wont work as you want it to.

 

[Arithos]

A proper way of using IF/ELSE, is stating, if cell B1 is "f", then do something, if its anything other then "f" then do something else...

Sub test()If Range("b1").Value = "f" Then
        Range("c7").Value = 500 / 2
    Else '
    MsgBox "Something else....."
End If
End Sub

 

[Gavin T]

Or you can use a Case statement which seems a bit more readable.

Sub GenderValue()

    Dim Gender   As String
    Dim Result   As Long

    Const cValue As Long = 500

    Gender = Range("B1")

    Select Case UCase(Gender)
        Case "F": Result = cValue / 2
        Case "M": Result = cValue / 3
    End Select

    Range("C7") = Result

End Sub

Note: I use UCase to remove the case sensitivity.

 

[montecarlo2012]

thanks, work for me.

 

[Gavin T]

Which one?

 

[montecarlo2012]

GAVIN thank you so much, now I will insert the real calculation, thanks again.

 

[montecarlo2012]

I rather gavin. thanks.

 

[Gavin T]

You're welcome.