if..then..else error vba

[winde]

Hi

Anyone able to help me debug my code below? it kept prompting me compile error: else without if

where did i make a mistake?


Dim s As String
Dim r As Long
Dim c As Long


'set active sheet
Set ws = ActiveSheet


'finds the last row
lstrow = ws.UsedRange.Rows.Count


c = 2


For r = 1 To lstrow

If Cells(r, c) = "" Then Cells(r, c) = Cells(r, c - 1)
Else
Cells(r, c) = Cells(r - 1, c)
End If


Next r


End Sub

 

[GirishDhruva]

Try

Dim s As String
Dim r, lstrow As Long
Dim c As Long
Dim ws As Worksheet


'set active sheet
Set ws = ActiveSheet
'finds the last row
lstrow = ws.UsedRange.Rows.Count


c = 2


For r = 1 To lstrow


If Cells(r, c) = "" Then
Cells(r, c) = Cells(r, c - 1)
Else
Cells(r, c) = Cells(r - 1, c)
End If


Next r

 

[GirishDhruva]

Try

Dim s As String
Dim r, lstrow As Long
Dim c As Long
Dim ws As Worksheet


'set active sheet
Set ws = ActiveSheet


'finds the last row
lstrow = ws.UsedRange.Rows.Count


c = 2


For r = 1 To lstrow


If Cells(r, c) = "" Then
Cells(r, c) = Cells(r, c - 1)
Else
Cells(r, c) = Cells(r - 1, c)
End If


Next r

 

[steve the fish]

This if:

If Cells(r, c) = "" Then Cells(r, c) = Cells(r, c - 1)

placed on one line doesnt require an end if. So as you have false conditions too you need:

If Cells(r, c) = "" Then 
Cells(r, c) = Cells(r, c - 1)
Else
Cells(r, c) = Cells(r - 1, c)
End If

 

[winde]

Thanks both..its working now

 

[Michael M]

Also, make sure you declare ALL variables

dim ws as worksheet, lstrow as long
Set ws = ActiveSheet
lstrow = ws.UsedRange.Rows.Count