If/Else/If/ElseIf - avoid repeating code

[fastballfreddy]

I have a code that works but I'm repeating part of my code 3 times (Action 2 below in the code) and want to see if there is a way to only have it once. My current code uses - If, Else, If, ElseIf to process.

The 3 scenarios are the outcomes that could happen. Is there a way to always run Action 2 at the end without repeating it 3 times?

• Action 1 & Action 2
• Action 3, Action 4 & Action 2
• Action 3, Action 5 & Action 2

Sub New Game()
IF CONDITION THEN
    ACTION 1 & ACTION 2 (WOULD LIKE TO BE RAN AFTER EVERYTHING REGARDLESS)

ELSE ACTION 3

IF CONDITION THEN
    ACTION 4 & ACTION 2 (WOULD LIKE TO BE RAN AFTER EVERYTHING REGARDLESS)

ELSEIF CONDITION THEN
    ACTION 5 & ACTION 2 (WOULD LIKE TO BE RAN AFTER EVERYTHING REGARDLESS)

End If
End If
End If

 

[Sam_D_Ben]

May be,

Sub NewGame()
    If Condition Then
        Action 1
        Action 2
    Else
        Action 3
    End If
    If Condition Then
        Action 4
    ElseIf Condition Then
        Action 5
    End If
    Action 2
End Sub

 

[6StringJazzer]

Your pseudo code doesn't match the scenarios and actions you described.

Are the three conditions cumulatively exhaustive? That is, is it possible for all of the conditions be FALSE? If so, yeah, you have to repeat it every time.

Another approach is

If Condition1 Then
   Action1
End If

If Condition1 Or Condition2 Or Condition3 Then
   Action2
End If

If Condition2 Or Condition3 Then
   Action3
End If

If Condition2 Then
   Action4
End If

If Condition3 Then
   Action5
End If

 

[fastballfreddy]

Thanks for the feedback. I got it to work. Appreciate it!

 

[ExcelVisual]

I have a code that works but I'm repeating part of my code 3 times (Action 2 below in the code) and want to see if there is a way to only have it once. My current code uses - If, Else, If, ElseIf to process.

The 3 scenarios are the outcomes that could happen. Is there a way to always run Action 2 at the end without repeating it 3 times?

• Action 1 & Action 2
• Action 3, Action 4 & Action 2
• Action 3, Action 5 & Action 2

Sub New Game()
IF CONDITION THEN
    ACTION 1 & ACTION 2 (WOULD LIKE TO BE RAN AFTER EVERYTHING REGARDLESS)

ELSE ACTION 3

IF CONDITION THEN
    ACTION 4 & ACTION 2 (WOULD LIKE TO BE RAN AFTER EVERYTHING REGARDLESS)

ELSEIF CONDITION THEN
    ACTION 5 & ACTION 2 (WOULD LIKE TO BE RAN AFTER EVERYTHING REGARDLESS)

End If
End If
End If

Why don't you use arrays and key-value operators in complex logical structures instead of repeating If statements multiple times?