if else function won't work

[ChanL]

Hi, currently writing a VBA where if the value of range I10 in sheet name Main is equal to 1H, then the value of range ("B20") in sheet name Part 1 would be January

sub working()

Dim reportprd as string

reportprd = thisworkbook.sheets("Main").Range("I10").value

if reportprd="1H" then
thisworkbook.sheets("Part 1").range("B20").value = "January"
else 
thisworkbook.sheets("Part 1").range("B20").value="February"
End if

end sub

i use some basic function to return the value of reportprd , it shows "1H". Bt i don't know why the value of the of B20 just won't change to January. in fact it showing february, which is not correct

 

[Georgiboy]

Try running the below and see what the message box states.

Sub working()
    Dim reportprd As String
    
    reportprd = ThisWorkbook.Sheets("Main").Range("I10").Value
    
    MsgBox Len(reportprd)
    
    If reportprd = "1H" Then
    ThisWorkbook.Sheets("Part 1").Range("B20").Value = "January"
    Else
    ThisWorkbook.Sheets("Part 1").Range("B20").Value = "February"
    End If

End Sub

 

[ChanL]

i got "3" from the msg box

 

[ChanL]

i think i know why, i think have an extra space after my 1H that why my if else function won't work, thanks for the reminder!

 

[ChanL]

i removed the extra space for 1H but somehow, the value still return as february? can advice?

 

[Georgiboy]

Maybe if we tidy up the string in the code:

Sub working()
    Dim reportprd As String
    
    reportprd = UCase(Trim(Sheets("Main").Range("I10").Value))
    
    If reportprd = "1H" Then
        Sheets("Part 1").Range("B20").Value = "January"
    Else
        Sheets("Part 1").Range("B20").Value = "February"
    End If
End Sub