maddog2168
New Member
- Joined
- Jan 27, 2009
- Messages
- 2
I have 4 cells with data,
I want to compare the 1st 2 to find which is the greater, from that result, then state which cell is for start of a line, then compare the 2nd 2 cells to find which is the greater, and from that result, then state which cell is for end of a line.
Draw line from stated cells
This is my code so far
It works up to Sub Add_Line, and this i where I am having trouble. So far I have manually inserted the cells I want the line to start and end from, but I would like to add it from the where I am trying to compare the values.
I am totally new at vba, so any help is really appreciated...
btw, the first sub is copied from someone else, why reinvent the wheel?
I want to compare the 1st 2 to find which is the greater, from that result, then state which cell is for start of a line, then compare the 2nd 2 cells to find which is the greater, and from that result, then state which cell is for end of a line.
Draw line from stated cells
This is my code so far
Code:
Sub Mail_ActiveSheet()
Dim FileExtStr As String
Dim FileFormatNum As Long
Dim Sourcewb As Workbook
Dim Destwb As Workbook
Dim TempFilePath As String
Dim TempFileName As String
Dim OutApp As Object
Dim OutMail As Object
Dim UserName As String
Call Add_Line
With Application
.ScreenUpdating = False
.EnableEvents = False
End With
Set Sourcewb = ActiveWorkbook
'Copy the ActiveSheet to a new workbook
Sheets("Results").Copy
'ActiveSheet.Copy
Set Destwb = ActiveWorkbook
'Determine the Excel version and file extension/format
With Destwb
If Val(Application.Version) < 12 Then
'You use Excel 97-2003
FileExtStr = ".xls": FileFormatNum = -4143
Else
'You use Excel 2007-2013
Select Case Sourcewb.FileFormat
Case 51: FileExtStr = ".xlsx": FileFormatNum = 51
Case 52:
If .HasVBProject Then
FileExtStr = ".xlsm": FileFormatNum = 52
Else
FileExtStr = ".xlsx": FileFormatNum = 51
End If
Case 56: FileExtStr = ".xls": FileFormatNum = 56
Case Else: FileExtStr = ".xlsb": FileFormatNum = 50
End Select
End If
End With
' 'Change all cells in the worksheet to values if you want
' With Destwb.Sheets(1).UsedRange
' .Cells.Copy
' .Cells.PasteSpecial xlPasteValues
' .Cells(1).Select
' End With
' Application.CutCopyMode = False
'Save the new workbook/Mail it/Delete it
TempFilePath = Environ$("temp") & "\"
TempFileName = "Part of " & Sourcewb.Name & " " & Format(Now, "dd-mmm-yy h-mm-ss")
UserName = Sheets("Results").Range("B1").Value
Set OutApp = CreateObject("Outlook.Application")
Set OutMail = OutApp.CreateItem(0)
With Destwb
.SaveAs TempFilePath & TempFileName & FileExtStr, FileFormat:=FileFormatNum
On Error Resume Next
With OutMail
.to = "email@domain.com"
.CC = ""
.BCC = ""
.Subject = "Test Results for" & " " & UserName
.Body = "Hi Admin" & vbNewLine & _
"Here are the test results for" & " " & UserName
.Attachments.Add Destwb.FullName
'You can add other files also like this
'.Attachments.Add ("C:\test.txt")
'.Send 'or use
.Display
End With
On Error GoTo 0
.Close savechanges:=False
End With
'Delete the file you have send
Kill TempFilePath & TempFileName & FileExtStr
Set OutMail = Nothing
Set OutApp = Nothing
With Application
.ScreenUpdating = True
.EnableEvents = True
End With
End Sub
Sub Add_Line()
Dim lbx As Long
Dim lby As Long
Dim lex As Long
Dim ley As Long
Dim lnStart As String
Dim lnEnd As String
If Range("C4").Value > Range("D4").Value Then
lnStart = Range("A18")
Else
lnStart = Range("I18")
End If
If Range("F4") > Range("G4") Then
lnEnd = Range("E7")
Else
lnEnd = Range("E29")
End If
With Range("I18")
lbx = .Left + .Width / 2
lby = .Top + .Height / 2
End With
With Range("E29")
lex = .Left + .Width / 2
ley = .Top + .Height / 2
End With
Sheet2.Shapes.AddLine lbx, lby, lex, ley
'Sheet1.Shapes.AddLine lbx, lby, lex, ley
'expression.AddLine(BeginX, BeginY, EndX, EndY)
End Sub
It works up to Sub Add_Line, and this i where I am having trouble. So far I have manually inserted the cells I want the line to start and end from, but I would like to add it from the where I am trying to compare the values.
I am totally new at vba, so any help is really appreciated...
btw, the first sub is copied from someone else, why reinvent the wheel?