Help pls! :'( Dictionary.exists always returning true and unable to use dictionary.

SBMa

New Member
Joined
Aug 17, 2022
Messages
8
Office Version
  1. 365
  2. 2021
  3. 2019
Platform
  1. Windows
I am attempting to check data imported from a sheet for duplicates with my current sheet.
I've added some of my current sheets data to a dictionary.
I then try to loop through an array of the imported data and check for duplicates in my using the array as a key

This isn't working and dictionary.exists always returns true
I know for a fact that the dictionary contains and have tested it with data that definitely has duplicates when it should be returning false.

two ways ive tried to compare the dictionary and array are
VBA Code:
'If DictDuplicates.Item(CStr(arrData(i, 1))) = arrData(i, 4) Then
  If DictDuplicates.Exists(arrData(i, 1) & """__""" & arrData(i, 4)) Then

Full Code Here
VBA Code:
Sub DuplicateCheckerImport()
'
' DuplicateCheckerImport Macro
' Tester !!!! Tester

Dim fileToOpen As Variant
Dim fileFilterPattern As String
Dim wsMaster As Worksheet
Dim wbTextImport As Workbook

Dim dlr As Long
Dim lr As Long
Dim lImpC As Long
Dim lImpR As Long
Dim DictDuplicates As Object
Dim countMatch As Long


Set DictDuplicates = CreateObject("Scripting.Dictionary")

Application.ScreenUpdating = False

Set wsMaster = ThisWorkbook.Worksheets("Asset Upload Data 2022")
    
  With wsMaster
    lr = .Cells(Rows.Count, 1).End(xlUp).Offset(1).Row
    dlr = .Cells(Rows.Count, 1).End(xlUp).Row
    For i = 1 To dlr
      ' adds time and asset name key/value pair
      DictDuplicates.Add .Cells(i, 6).Text, .Cells(i, 3).Text
      
    Next i
    
  End With

fileFilterPattern = "Microsoft Excel Workbooks (*.xls*),*.xls*"

fileToOpen = Application.GetOpenFilename(fileFilterPattern)

' open workbook

If fileToOpen = False Then
  ' input Cancelled
  MsgBox "No file Selected."
Else

  Workbooks.OpenText _
    Filename:=fileToOpen, _
    StartRow:=2, _
    DataType:=xlDelimited, _
    Tab:=True

  Set wbTextImport = ActiveWorkbook
  
' limpC last column with data
' limmpR last row with data
  With wbTextImport.Worksheets(1)
    lImpC = .Cells(1, .Columns.Count).End(xlToLeft).Column
    lImpR = .Cells(Rows.Count, 1).End(xlUp).Row
    
    arrData = .Range("A1:D" & lImpR).Value
  End With
End If

'Dim y As Variant
'For Each y In arrData
 '   Debug.Print y
'Next

countMatch = 0
' Now you can work on the array
For i = LBound(arrData) To UBound(arrData) ' I'm assuming the data copied has headers, if not, change 2 for 1
                               '  Debug.Print DictDuplicates.Exists(arrData(i, 1)) & "fuu"
 
' If DictDuplicates.Item(CStr(arrData(i, 1))) = arrData(i, 4) Then
  If DictDuplicates.Exists(arrData(i, 1) & """__""" & arrData(i, 4)) Then
                ' If the concatenated data exists on the dictionary
    MsgBox "Duplicates found, please check data you are attempting to copy"
    countMatch = countMatch + 1
    Exit For
            
  Else
' If it doesn't import worksheet from a2 to last cells with data on this worksheet from lr in c
    If countMatch = 0 And i = UBound(arrData) Then
      With wbTextImport.Worksheets(1)
        .Range("A2", .Cells(lImpR, lImpC)).Copy wsMaster.Range("C" & lr)
      End With
    
      wbTextImport.Close False
    End If
 
  End If
Next i

    
Application.ScreenUpdating = True
'
End Sub
 

Excel Facts

Show numbers in thousands?
Use a custom number format of #,##0,K. Each comma after the final 0 will divide the displayed number by another thousand
Are you sure you want the two sets of triple quotes?

i.e. if arrData(i, 1) = test and arrData(i, 4) = 123, is the string you're looking in the dictionary truly test"__"123?

Or do you want it to be test__123 where your concatenation should be
Code:
& "__" &
instead of
Code:
& """__""" &
?
 
Upvote 0
Are you sure you want the two sets of triple quotes?

i.e. if arrData(i, 1) = test and arrData(i, 4) = 123, is the string you're looking in the dictionary truly test"__"123?

Or do you want it to be test__123 where your concatenation should be
Code:
& "__" &
instead of
Code:
& """__""" &
?
you are correct! thank you
That set me In the right direction and now everything works
 
Upvote 0

Forum statistics

Threads
1,223,164
Messages
6,170,444
Members
452,326
Latest member
johnshaji

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top