Help on making this code Run faster, Takes like a minute

DarrenBurke

New Member
Joined
May 6, 2022
Messages
29
Office Version
  1. 2016
  2. 2007
Platform
  1. Windows
Hi, Guys and gals,
Can i tweak this code to run faster.
What are you trying to do ? I want the code to check colum "A" for empty cells and delete the entire row. (Basically the telesales did not capture the correct info, therefore the row of info is useless and needs to be deleted. ) It works as is but takes a long time to finish. I have 10 other sheets to apply it to with a macro on each sheet. Thank you to the Hive Minds :)

VBA Code:
Sub Delete_Rows_with_Blank_Cells_in_Single_Column()

Worksheets("MichaelF").Activate

Set Rng = ActiveSheet.UsedRange

Blank_Cells_Column = 1

For i = Rng.Rows.Count To 1 Step -1
    If Rng.Cells(i, Blank_Cells_Column) = "" Then
        Rng.Cells(i, Blank_Cells_Column).EntireRow.Delete
    End If
Next i
   
End Sub

I hope i did the code correctly

Cheers
 

Excel Facts

Lock one reference in a formula
Need 1 part of a formula to always point to the same range? use $ signs: $V$2:$Z$99 will always point to V2:Z99, even after copying
Hi & welcome to MrExcel.
How about
VBA Code:
Sub DarrenBurke()
   Range("A:A").SpecialCells(xlBlanks).EntireRow.Delete
End Sub
 
Upvote 0
Hi & welcome to MrExcel.
How about
VBA Code:
Sub DarrenBurke()
   Range("A:A").SpecialCells(xlBlanks).EntireRow.Delete
End Sub
Hi Fluff, thank you for the speedy response, i get a 1004 runtime error, please see attachment Snapshot. Thank you for your time. :)
 

Attachments

  • runtimeerror1004.JPG
    runtimeerror1004.JPG
    253.8 KB · Views: 17
Upvote 0
Ok, it looks like you are using a table which is causing the problem, what is the name of the table?
 
Upvote 0
Give this a try with a copy of your workbook.
I have assumed just one ListObject (formal table) on the sheet.

VBA Code:
Sub Del_Rws()
  Dim a As Variant, b As Variant
  Dim nc As Long, i As Long, k As Long, Blank_Cells_Column As Long
  
  Blank_Cells_Column = 1
  
  With Sheets("MichaelF").ListObjects(1)
    a = .DataBodyRange.Columns(Blank_Cells_Column).Value
    ReDim b(1 To UBound(a), 1 To 1)
    For i = 1 To UBound(a)
      If Len(a(i, 1)) = 0 Then
        b(i, 1) = 1
        k = k + 1
      End If
    Next i
    If k > 0 Then
      Application.ScreenUpdating = False
      .ListColumns.Add
      With .DataBodyRange
        nc = .Columns.Count
        .Columns(nc).Value = b
        .Sort Key1:=.Columns(nc), Order1:=xlAscending, Header:=xlYes
        .Resize(k).EntireRow.Delete
      End With
      .ListColumns(nc).Delete
      Application.ScreenUpdating = True
    End If
  End With
End Sub
 
Upvote 0
Ok, it looks like you are using a table which is causing the problem, what is the name of the table?
Ok Well spotted Fluff. This table has a data connection to source file it updates on open bringing any new data. 3 captures per A4 page, the have not completed the other 2, thefore 2 blanks.
Table name is Table_Michael_Pickup attached snapshot
 

Attachments

  • TableName.JPG
    TableName.JPG
    158.1 KB · Views: 16
Upvote 0
Ok, give Peter's code a go, if you have a lot of data it will be faster than what I suggested.
 
Upvote 0
Give this a try with a copy of your workbook.
I have assumed just one ListObject (formal table) on the sheet.

VBA Code:
Sub Del_Rws()
  Dim a As Variant, b As Variant
  Dim nc As Long, i As Long, k As Long, Blank_Cells_Column As Long
 
  Blank_Cells_Column = 1
 
  With Sheets("MichaelF").ListObjects(1)
    a = .DataBodyRange.Columns(Blank_Cells_Column).Value
    ReDim b(1 To UBound(a), 1 To 1)
    For i = 1 To UBound(a)
      If Len(a(i, 1)) = 0 Then
        b(i, 1) = 1
        k = k + 1
      End If
    Next i
    If k > 0 Then
      Application.ScreenUpdating = False
      .ListColumns.Add
      With .DataBodyRange
        nc = .Columns.Count
        .Columns(nc).Value = b
        .Sort Key1:=.Columns(nc), Order1:=xlAscending, Header:=xlYes
        .Resize(k).EntireRow.Delete
      End With
      .ListColumns(nc).Delete
      Application.ScreenUpdating = True
    End If
  End With
End Sub
Thank you so much Peter it works in milliseconds.... WOW!!
Thank you Fluff, Both Champions
Cheers from a chilly South Africa
 
Upvote 0

Forum statistics

Threads
1,223,911
Messages
6,175,327
Members
452,635
Latest member
laura12345

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top