Having trouble with IF statement.

[Wamhoi]

Hi All,

I keep getting an error with the following If statement

Dim lastline As Long
lastline = Cells(Rows.Count, 2).End(xlUp).Row
For i = 2 To lastline

        If Cells(i, 1).Value = "R" Then _
            Cells(i, 1).Select
            Selection.Interior.Color = 192
        ElseIf Cells(i, 1).Value = "A" Then _
            Cells(i, 1).Select
            Selection.Interior.Color = 49407
        Else: Cells(i, 1).Select
            Selection.Interior.Color = 5296274
        End If
Next i

 

[Scott Huish]

Why don't you just use Conditional Formatting?

Also, you don't need to Select or Activate cells in order to work with them, you can work with cells/ranges directly. I would also use Select Case instead of that structure:

Sub test()
Dim lastline As Long, lngColor As Long
lastline = Cells(Rows.Count, 2).End(xlUp).Row
For i = 2 To lastline
    Select Case UCase(Cells(i, 1))
        Case "R": lngColor = 192
        Case "A": lngColor = 49407
        Case Else: lngColor = 5296274
    End Select
    Cells(i, 1).Interior.Color = lngColor
Next i
End Sub

 

[texasalynn]

remove the underscore

If Cells(i, 1).Value = "R" Then
            Cells(i, 1).Interior.Color = 192
        ElseIf Cells(i, 1).Value = "A" Then
            Cells(i, 1).Interior.Color = 49407
        Else: Cells(i, 1).Interior.Color = 5296274
        End If

<!-- / message -->