Generate Report Using If...ElseIf...End If Construct

[AlexB123]

Hi all,

I'm making some changes to the images that go out on certain reports. I have a report that is tied to a combobox of client ID's and produces a single report but has an image I want to change. I need to produce a second report, with a different logo, if the client ID is equal to one of two values.

First I tried:

 'If statement to allow for new rptLettersSBD when ClientID = ABC001 or ABC002
        If ((Forms!frmLetter.cmbClientID = "ABC001") Or (Forms!frmLetter.cmbClientID = "ABC002")) Then
                DoCmd.OutputTo acOutputReport, "rptLetterSBD", acFormatPDF, PDFFileName, False
        Else
                DoCmd.OutputTo acOutputReport, "rptLetterBranded", acFormatPDF, PDFFileName, False
        End If

Then I tried:

'If statement to allow for new rptLettersSBD when ClientID = ABC001 or ABC002
        If Forms!frmLetter.cmbClientID = "ABC001" Then
                DoCmd.OutputTo acOutputReport, "rptLetterSBD", acFormatPDF, PDFFileName, False
        ElseIf Forms!frmLetter.cmbClientID = "ABC002" Then
                DoCmd.OutputTo acOutputReport, "rptLetterSBD", acFormatPDF, PDFFileName, False
        Else
                DoCmd.OutputTo acOutputReport, "rptLetterBranded", acFormatPDF, PDFFileName, False
        End If

The first code block successfully produced a report for the first ClientID. My database crashed when I used the second code block to try and get the report for the second ClientID.

Thanks for any assistance!

 

[xenou]

I would guess the crash is not related to the use of If-elseif-else-end here. That is perfectly good vba syntax as far as I can tell.

 

[Joe4]

I am not a big fan of "ElseIf". I often get confused on whether or not I need an "End If" with it. For multiple options, I prefer CASE statements, i.e.

 'If statement to allow for new rptLettersSBD when ClientID = ABC001 or ABC002
        Select Case Forms!frmLetter.cmbClientID
            Case "ABC001", "ABC002"
                DoCmd.OutputTo acOutputReport, "rptLetterSBD", acFormatPDF, PDFFileName, False
            Case Else
                DoCmd.OutputTo acOutputReport, "rptLetterBranded", acFormatPDF, PDFFileName, False
        End Select

If you have other conditions, you can add more Cases.
See: https://www.techonthenet.com/excel/formulas/case.php
(though the link is for Excel VBA, it works exactly the same way in Access VBA).

 

[AlexB123]

Xenou, thank you for looking over the syntax.

I found that when I reloaded the form everything worked. There still seem to be kinks related to queries and such, so I appreciate the feedback.

Joe4, thank you for the suggestion! I, too, prefer case statements, and will try that out.