Function to return a string

[Grant22]

Hello all, I am trying to write a function that returns a manager’s name based on the name in a column. So if column F has “John Doe” or “Jane Doe” it will return a different value based on who their manager is. But I keep getting a blank return when I enter the info. Can someone please see what I amdoing wrong? Any help is greatly appreciated!

[FONT=Calibri][SIZE=3][COLOR=#000000]Public Function Manager(ManagerName As String) As String[/COLOR][/SIZE][/FONT]

[FONT=Calibri][SIZE=3][COLOR=#000000]Select Case UCase(ManagerName)[/COLOR][/SIZE][/FONT]
[FONT=Calibri][SIZE=3][COLOR=#000000]
Case "John Doe","Joe Doe"[/COLOR][/SIZE][/FONT]

[FONT=Calibri][SIZE=3][COLOR=#000000]        Manager = "Sally Sue"[/COLOR][/SIZE][/FONT]

[FONT=Calibri][SIZE=3][COLOR=#000000]Case "Jane Doe" , “Dan Doe”[/COLOR][/SIZE][/FONT]

[FONT=Calibri][SIZE=3][COLOR=#000000]        Manager = "Mary Smith"[/COLOR][/SIZE][/FONT]

[FONT=Calibri][SIZE=3][COLOR=#000000]End Select[/COLOR][/SIZE][/FONT]
[FONT=Calibri][SIZE=3][COLOR=#000000]
End Function
[/COLOR][/SIZE][/FONT]

 

[Fluff]

Your using UCase, but none of the options are upper case, so it can't find them, try

Public Function Manager(ManagerName As String) As String

Select Case LCase(ManagerName)

Case "john doe", "joe doe"

        Manager = "Sally Sue"

Case "jane doe", "dan doe"

        Manager = "Mary Smith"

End Select

End Function

 

[Grant22]

Thanks very much for the response that worked but I'm not sure why. When the value is passed on from the cell to the function it's in proper case so why wouldn't it work in Ucase or Lcase? I guess I don't fully understand the difference. Thanks!

 

[Fluff]

UCase converts the value to uppercase, so John Doe becomes JOHN DOE. Therefore the select case won't find a match as none of the values to match were in upper case.

 

[Grant22]

Oh ok thanks for the info. Is there a version that accepts it in proper case? Like PCase for example?

 

[Fluff]

Not in VBA. You can use the worksheet function, but there is no need if the code I supplied worked.

 

[Norie]

If you want proper case in VBA use StrConv(expression, vbProperCase)

 

[Grant22]

Thanks guys!!

 

[Fluff]

You're welcome