Filling dynamic arrays vba

[rharn]

I am trying to fill a dynamic array with the row indexes from a search function. So far I have created a loop that introduces a leading or trailing 0 to fill the array. I would like to fill the array without the 0 but my current code keeps giving me a 'subscript out of range' error. This should be a easy fix, I just dont understand VBA enough to fix it myself. All help appreciated!

    Dim Results1() As Variant
    Dim TextBox1 As Long
    Dim FindRange1 As Range
    Dim Find1 As Range
    Dim i1 As Long

    ReDim Results1(1)
    TextBox1 = ILsearch.TextBox1.Value
 
                If ILsearch.P1B1.Value = True Then
                    For Each Find1 In FindRange1
                        If (Find1.Value < TextBox1) And (Find1.Value > 0) Then
                            Results1(i1) = Find1.Row
                            i1 = i1 + 1
                            ReDim Preserve Results1(i1)
                        End If
                    Next Find1
                End If

 

[p45cal]

You haven't got
Option Base 1
at the top somewhere have you?

 

[rharn]

option base 1 was specified, sorry i forgot to include that

 

[p45cal]

Then that's why it's failing. You haven't set the value of il before using it, so it's 0 at that point.
If Option Base 1 is required for something else you can explicitly
redim Results(0 to 0) but within your loop, you must also
Redim preserve Results(0 to il)

Or of course, just initialise il to 1 before using it for the first time, then leave everything else as it was.
Even simpler, remove Option Base 1 if it's not required.

 

[p45cal]

Thanks p45cal, that sorted it.