Failing to use VBA to change color when conditions are met

[rizzo93]

I've looked at several similar examples of the issue I'm having, but I'm still missing something.


I want to change the color of a frame to red when a cell value is NOT "on hold" and when another cell value is either NOT "ND" or NOT over 100%. Otherwise, I want the frame to stay the original color (the RGB definition).

        If Worksheets("Details").Range("D16") <> "On Hold" Then
            If Worksheets("Details").Range("O13") = "ND" Or Worksheets("Details").Range("O13") > 0.1 Then
                Me.DaysFrame.BorderColor = vbRed
            Else
                Me.DaysFrame.BorderColor = RGB(128, 128, 128)
            End If
        End If

I've tried variations like this portion of code:

If Worksheets("Details").Range("D16") <> "On Hold" And (Worksheets("Details").Range("O13") = "ND" Or Or Worksheets("Details").Range("O13") > 0.1) Then...

But the solution continues elude me.

 

[rizzo93]

I should have said that the result of the code I provided above always gives me a red border despite the conditions.

 

[Rick Rothstein]

I've looked at several similar examples of the issue I'm having, but I'm still missing something.


I want to change the color of a frame to red when a cell value is NOT "on hold" and when another cell value is either NOT "ND" or NOT over 100%. Otherwise, I want the frame to stay the original color (the RGB definition).

        If Worksheets("Details").Range("D16") <> "On Hold" Then
            [B][COLOR="#FF0000"]If Worksheets("Details").Range("O13") = "ND" Or Worksheets("Details").Range("O13") > 0.1 Then[/COLOR][/B]
                Me.DaysFrame.BorderColor = vbRed
            Else
                Me.DaysFrame.BorderColor = RGB(128, 128, 128)
            End If
        End If

(Untested) Based on your written description, I would think your second If..Then statement should be this...

[table="width: 500"]
[tr]
	[td]If Worksheets("Details").Range("O13") <> "ND" Or Worksheets("Details").Range("O13") < 1 Then[/td]
[/tr]
[/table]

 

[rizzo93]

Thanks, Rick. I did a poor job of writing that. I should have said if that range is equal to ND or the other range is greater than 100%.

 

[rizzo93]

My logic seemed correct, so that left my calculations and that's where I found the problem. I was testing against the wrong figure. Frustrating, but at least the issue is solved.


Thanks again, Rick, for your help though.