Error passing variables to a userform

[Ark68]

I have variables fix_type and fix_name declared publically as string.

Public fix_type As String
Public fix_name As String

When I run my code and get to this point of opening my userform, both variables have values.

...
    Case 1
        fix_type = "NDB"
        valid_freq fixpropcancel
        Stop
        Coordinates.Show
    Case 2
...

I get an error (object required) in my Userform Initialization mode (lines highlighted red) when I try to assign these variable's values to their respective labels on the userform. Both "fx_type" and fx_name" are valid lable names in my userform. Looking to have my error revealed.

Private Sub UserForm_Initialize()
    Caption = "FIX COORDINATES"
    fx_type.Caption = fix_type.Value
    fx_name.Caption = fix_name.Value
    btn_accept.Enabled = False
    lat_dd.Value = "00.000000"
    long_dd.Value = "00.000000"
    lat_dm_d.Value = "00"
    lat_dm_min.Value = "00"
    long_dm_d.Value = "00"
    lon_dm_min.Value = "00"
    lat_dms_d.Value = "00"
    lat_dms_min.Value = "00"
    lat_dms_sec.Value = "00.000"
    long_dms_d.Value = "00"
    lon_dms_min.Value = "00"
    long_dms_sec.Value = "00.000"
End Sub

 

[DanteAmor]

But variables are not controls therefore, they should not carry .Value:

fx_type.Caption = fix_type
fx_name.Caption = fix_name

 

[Ark68]

Ah right. Sometimes the obvious eludes me. Thank you Dante for the reminder.
But something's still not right. The values of those variables isn't being passed into the label control.

 

[DanteAmor]

Where do you have the variables declared?

If you put them in the module. Works.


In Module:

Option Explicit

Public fix_type As String
Public fix_name As String

Sub llamada()
  Dim n
  n = 1
  Select Case n
    Case 1
        fix_type = "NDB"
        Coordinates.Show
    Case 2
    
  End Select
End Sub

In userform:

Private Sub UserForm_Initialize()

    fx_type.Caption = fix_type
    fx_name.Caption = fix_name

End Sub

And that works.

 

[Ark68]

And that works.

Yes it does. Does it matter in which module of a project you put Public declarations? I had them in Module 2 between two subs. I assume that's improper.

 

[DanteAmor]

Does it matter in which module of a project you put Public declarations?

The module doesn't matter. I tested it and it works if the public declarations are in another module.

 

[Ark68]

I actually found the source of my issue. I had forgotten to remove the original Dim declarations of those variables in the module. I think they over rode the public declaration.