Error handling

[tiredofit]

Is it good practice to always follow an on error with a resume?

For example, method 1:

Sub Start()

On Error GoTo Errhandler

    a = 0
    b = 10 / a

On Error GoTo 0

' do something

Terminate:

    On Error GoTo 0

Exit Sub

Errhandler:

   Msgbox "Div by 0"

   Resume Terminate

End Sub

or will method 2 suffice?

Sub Start()

On Error GoTo Errhandler

 
    a = 0
    b = 10 / a


On Error GoTo 0


' do something


GoTo Terminate

Errhandler:


   Msgbox "Div by 0"

Terminate:
   
    On Error GoTo 0
    
End Sub

Thanks

 

[RoryA]

#2 would technically suffice, though I prefer #1 , not least because you only need to put any clean up code in one place. There is no need for the On Error Goto 0 in either one.

 

[tiredofit]

Thanks

There is no need for the On Error Goto 0 in either one.

because exiting the Sub takes care of things but surely in method 1, the first On Error GoTo 0 is required, ie:

Sub Start()

On Error GoTo Errhandler

    a = 0
    b = 10 / a

On Error GoTo 0

 

[RoryA]

Yes, if you intended to stop handling errors at that point.

 

[tiredofit]

Thanks