error file already exists when move file from folder to another

[Maklil]

Hi experts
it gives me error file already exists in this line

  FSO.MoveFile Source:=SourcePath & NameFile, Destination:=DestPath

when try move file from folder to another
so should move file extraction 10 Oct. 2022 (1).xlsx from directory C:\Users\PC lLATER\Downloads\ to directory
C:\Users\PC WORLD\output\rep
how can I fix error?
how can I add more than file name into array like this ("extraction 10 Oct. 2022 (1).xlsx" , "report.pdf", "pictures.jpg","montly.docx")?

Sub Move_Folder()

    Dim FSO As Object
    Dim SourcePath As String
    Dim DestPath As String
    Dim NameFile As String

    SourcePath = "C:\Users\PC lLATER\Downloads\"  '<< Change as needed
    DestPath = "C:\Users\PC lLATER\output\rep"    '<< Change as needed
    NameFile = "extraction 10 Oct. 2022 (1).xlsx"       '<< Change as needed

    Set FSO = CreateObject("scripting.filesystemobject")

    If FSO.FolderExists(Left(SourcePath, Len(SourcePath) - 1)) = False Then
        MsgBox SourcePath & " doesn't exist"
        Exit Sub
    End If

    'to move
    FSO.MoveFile Source:=SourcePath & NameFile, Destination:=DestPath

End Sub

is there any chance to make this code works efficiantly ?

 

[rollis13]

If these file names as static you could use your macro with only these few changes:

Option Explicit
Sub Move_Folder()
    Dim FSO    As Object
    Dim SourcePath As String
    Dim DestPath As String
    Dim NameFile As Variant                       '<- changed
    Dim x      As Long                            '<- added
    SourcePath = "C:\Users\PC lLATER\Downloads\"  '<< Change as needed
    DestPath = "C:\Users\PC lLATER\output\rep"    '<< Change as needed
    NameFile = Array("extraction 10 Oct. 2022 (1).xlsx", "report.pdf", "pictures.jpg", "monthly.docx") '<- changed
    Set FSO = CreateObject("scripting.filesystemobject")
    If FSO.FolderExists(Left(SourcePath, Len(SourcePath) - 1)) = False Then
        MsgBox SourcePath & " doesn't exist"
        Exit Sub
    End If
    'to move
    For x = LBound(NameFile) To UBound(NameFile)  '<- added
        FSO.MoveFile Source:=SourcePath & NameFile(x), Destination:=DestPath '<- changed
    Next x                                        '<- added
End Sub

 

[Maklil]

this really works .
many thanks buddy

 

[rollis13]

Thanks for the positive feedback, glad having been of some help.

 

[Maklil]

sorry buddy !
just I want getting rid of the error when one of them the file name is not existed
how can I add procedure to show me message what's the name file is not existed and finish the prcodure without do any thing ?

 

[rollis13]

Now the macro will give you feedback for the file names that had problems (missing source or destination already present).

Option Explicit
Sub Move_Folder()
    Dim FSO    As Object
    Dim SourcePath As String
    Dim DestPath As String
    Dim NameFile As Variant
    Dim x      As Long
    Dim msgDiag As String
    msgDiag = "Had problems with:" & vbLf
    SourcePath = "C:\Users\PC lLATER\Downloads\"  '<< Change as needed
    DestPath = "C:\Users\PC lLATER\output\rep"    '<< Change as needed
    NameFile = Array("extraction 10 Oct. 2022 (1).xlsx", "report.pdf", "pictures.jpg", "monthly.docx")
    Set FSO = CreateObject("Scripting.FileSystemObject")
    If FSO.FolderExists(Left(SourcePath, Len(SourcePath) - 1)) = False Then
        MsgBox SourcePath & " doesn't exist"
        Exit Sub
    End If
    'to move
    On Error GoTo diag
    For x = LBound(NameFile) To UBound(NameFile)
        FSO.MoveFile Source:=SourcePath & NameFile(x), Destination:=DestPath
    Next x
    If msgDiag <> "" Then MsgBox msgDiag
    Exit Sub
diag:
    msgDiag = msgDiag & NameFile(x) & vbLf
    Resume Next
End Sub

 

[Maklil]

again thanks very much for new version