Error adding code for Combo box drop down list

[Patriot2879]

Hi, I have the code below but I am getting an error, the situation is I have two combo boxes in a userform and the boxes are filled in with data from my 'IN DAY LISTS' sheet, but it doesn't work when I added ComboBox1 coding below, please can you help me? I appreciate all your help with this

Private Sub UserForm_Initialize()
ComboBox2.RowSource = ""
    ComboBox2.List = Sheets("IN DAY LISTS").Range("D2", Sheets("IN DAY LISTS").Range("D" & Rows.Count).End(xlUp)).Value
ComboBox1.RowSource = ""
    ComboBox1.List = Sheets("IN DAY LISTS").Range("C2", Sheets("IN DAY LISTS").Range("C" & Rows.Count).End(xlUp)).Value
End With

End Sub

 

[Vbagreenhorn1]

please try this:

Private Sub UserForm_Initialize()
ComboBox2.RowSource = ""
    ComboBox2.List = Sheets("IN DAY LISTS").Range("D2:D" & Sheets("IN DAY LISTS").Range("D" & Rows.Count).End(xlUp).Row).Value
ComboBox1.RowSource = ""
    ComboBox1.List = Sheets("IN DAY LISTS").Range("C2:C" & Sheets("IN DAY LISTS").Range("C" & Rows.Count).End(xlUp).Row).Value
End With
End Sub

 

[Patriot2879]

still the same unfortunately with the 'End With'
What did you change sorry for asking but I couldn't see it. Thank you for your help though

 

[Vbagreenhorn1]

My bad! Remove "End With"

Private Sub UserForm_Initialize()
ComboBox2.RowSource = ""
    ComboBox2.List = Sheets("IN DAY LISTS").Range("D2:[COLOR=#ff0000]D"[/COLOR] & Sheets("IN DAY LISTS").Range("D" & Rows.Count).End(xlUp).[COLOR=#ff0000]Row).[/COLOR]Value
ComboBox1.RowSource = ""
    ComboBox1.List = Sheets("IN DAY LISTS").Range("C2:[COLOR=#ff0000]C"[/COLOR] & Sheets("IN DAY LISTS").Range("C" & Rows.Count).End(xlUp).[COLOR=#ff0000]Row[/COLOR]).Value

End Sub

Or use this one with "With"

Private Sub UserForm_Initialize()
With Sheets("IN DAY LISTS")
    ComboBox2.RowSource = ""
    ComboBox2.List = .Range("D2:D" & .Range("D" & Rows.Count).End(xlUp).Row).Value
    ComboBox1.RowSource = ""
    ComboBox1.List = .Range("C2:C" & .Range("C" & Rows.Count).End(xlUp).Row).Value
End With
End Sub

 

[Fluff]

Alternatively

Private Sub UserForm_Initialize()
With Sheets("IN DAY LISTS")
   ComboBox2.RowSource = ""
       ComboBox2.List = .Range("D2", .Range("D" & Rows.Count).End(xlUp)).Value
   ComboBox1.RowSource = ""
       ComboBox1.List = .Range("C2", .Range("C" & Rows.Count).End(xlUp)).Value
End With

End Sub

 

[Patriot2879]

That works great thank you for your help, much appreciated

 

[Fluff]

Glad we could help & thanks for the feedback