email notification on success only

[Babynod]

Hi All,

currently i have my Submit button set to email a notification, the button gets clicked, email is sent to me.
the issue with this is the email is sent event if there is an error, (duplicate validation failed, empty field that must be filled in, etc)
i want the email to only be sent on a successful update from my userform, not every time the button is clicked

Private Sub cmdSubmit_Click()
    
    Application.EnableEvents = False
    
    
    Dim msgvalue As VbMsgBoxResult
    
    msgvalue = MsgBox("Do you want to save the data?", vbYesNo + vbInformation, "confirmation")
    
    If msgvalue = vbNo Then Exit Sub
    If ValidateEntries() = True Then
    
        Call Submit
        Call reset
    End If
    
    
'email notification

Dim xOutApp As Object
    Dim xOutMail As Object
    On Error Resume Next
    
    Set xOutApp = CreateObject("Outlook.Application")
    Set xOutMail = xOutApp.CreateItem(0)
      
             
                  On Error Resume Next
    With xOutMail
        '.To = "MarkP@bapcor.com.au; markjpollock91@gmail.com"
        .To = "MarkP@Bapcor.com.au"
        .CC = ""
        .BCC = ""
        .Subject = "WMS LOGIN REGISTER"
        .Body = "Account Creation Requested By " & (Application.UserName)
        .Send
    End With
    On Error GoTo 0
    Set xOutMail = Nothing
    Set xOutApp = Nothing

    Application.EnableEvents = True
    

End Sub

 

[dmt32]

Hi,
Untested & bit of a guess but see if this update to your code does what you want

Private Sub cmdSubmit_Click()
    
    Dim xOutApp     As Object
    Dim xOutMail    As Object
    Dim msgvalue    As VbMsgBoxResult
    
    On Error GoTo myerror
    
    msgvalue = MsgBox("Do you want To save the data?", vbYesNo + vbInformation, "confirmation")
    
    If msgvalue = vbNo Then Exit Sub
    
    If ValidateEntries() = True Then
        Application.EnableEvents = False
        Call Submit
        Call Reset
    Else
        Err.Raise 600, , "duplicate validation failed or empty field must be filled"
    End If
    
    'email notification
    
    Set xOutApp = CreateObject("Outlook.Application")
    Set xOutMail = xOutApp.CreateItem(0)
    
    With xOutMail
        '.To = "MarkP@bapcor.com.au; markjpollock91@gmail.com"
        .To = "MarkP@Bapcor.com.au"
        .CC = ""
        .BCC = ""
        .Subject = "WMS LOGIN REGISTER"
        .Body = "Account Creation Requested By " & (Application.UserName)
        .Send
    End With
    
myerror:
    Application.EnableEvents = True
    Set xOutMail = Nothing
    Set xOutApp = Nothing

    If Err <> 0 Then MsgBox (Error(Err)), 48, "Error"
    
End Sub

Dave

 

[Babynod]

Hi Dave,

that seems to work so far, how would i not have the error 600 message box show up though, as currently when a empty field and duplicate entry is found i have a msgbox pop up, this is just doubling up.

 

[Babynod]

Hi Dave,

that seems to work so far, how would i not have the error 600 message box show up though, as currently when a empty field and duplicate entry is found i have a msgbox pop up, this is just doubling up.

i ended up just commenting out the

If Err <> 0 Then MsgBox (Error(Err)), 48, "Error"

and it worked

 

[Babynod]

i ended up just commenting out the

If Err <> 0 Then MsgBox (Error(Err)), 48, "Error"

and it worked

ok for some reason when i use your submit code, it doesnt add my latest data entry to the first row like it used to. it adds it to the last row but im not sure what part of the code does that as i cant see anything in the cmdsubmit that would do that

 

[dmt32]

Hi Dave,

that seems to work so far, how would i not have the error 600 message box show up though, as currently when a empty field and duplicate entry is found i have a msgbox pop up, this is just doubling up.

As I stated, solution untested & a bit of a guess as you had not shared all the codes your procedure is calling in particular, ValidateEntries function.
If this returns false then as per your requirement, no email will be sent & I added msgbox informing user

Dave