Else If Statements

[AK_Excel_13]

Why doesn't my else if statement work? I seems like it should work. The error I keep getting is "Else without If"

Application.ScreenUpdating = False
Set x = ActiveCell
Count = Range("a65536").End(xlUp).Row


For e = 2 To Count
If Cells(e, 10).Value = "A" Then Cells(e, 10).Value = "Yes"
Else: If Cells(e, 10).Value = "B" Then Cells(e, 10).Value = "No"
End If
End If
Next e


x.Select
Application.ScreenUpdating = True

 

[Special-K99]

Ignore this, my mistake.

 

[AK_Excel_13]

No it does not work. I get the same error message.

 

[Special-K99]

If you only have two values "A" and "B" then this should suffice

If Cells(e, 10).Value = "A" Then
Cells(e, 10).Value = "Yes"
Else: Cells(e, 10).Value = "No"
End If

 

[Special-K99]

this seems to work

If Cells(e, 10).Value = "A" Then
Cells(e, 10).Value = "Yes"
Else
If Cells(e, 10).Value = "B" Then
Cells(e, 10).Value = "No"
End If
End If

 

[CharlesChuckieCharles]

Needs to be a bit clearer


also Count is a reserved word ( its a function so best not use it)

Application.ScreenUpdating = False
Set X = ActiveCell
MyCount = Cells(Rows.Count, "A").End(xlUp).Row

For e = 2 To MyCount
    If Cells(e, 10).Value = "A" Then
        Cells(e, 10).Value = "Yes"
    ElseIf Cells(e, 10).Value = "B" Then
            Cells(e, 10).Value = "No"
    End If
Next e

X.Select
Application.ScreenUpdating = True

 

[AK_Excel_13]

I have multiple values. Thanks anyway!

 

[AK_Excel_13]

I tried again it worked. I'm not sure what I did wrong before. Thanks for the help!

 

[AK_Excel_13]

I will not use Count anymore. I will now use MyCount. Thanks for the advice!

 

[CharlesChuckieCharles]

just as a note

when you put condition and action on one line

If Cells(e, 10).Value = "A" Then Cells(e, 10).Value = "Yes"

it imples an EndIf at the end ( to the compiler)

If Cells(e, 10).Value = "A" Then Cells(e, 10).Value = "Yes" EndIf


The professional approach is always to give a standard shape to conditions using the indent

If Cells(e, 10).Value = "A" Then 
    Cells(e, 10).Value = "Yes" 
EndIf[COLOR=#ff0000]
[/COLOR]

So other coders can easily see at a glance that it is a condition