Dynamic Array to string

[PanzerRanger]

Why does the debug.printout generate an error (run time 5: Invalid procedure call or argument)? If I print a single item in the array it works. If I use a static array the debug.print works. Also is there a solution to get the printout to show as date, it now prints f.e. 42837 instead of 2017-04-12

Sub test()
Dim nr, a, c As Integer, ary() As Long, info As String, dat as date
lrnr = Blad1.Range("A" & Rows.Count).End(xlUp).Row
nr = lrnr - 25 'Read lrnr as 38
a = 1
c = 26

ReDim ary(a To nr)


Do
dat = Range("A" & c).Value
ary(a) = dat
c = c + 1
a = a + 1
Loop Until c > lrnr


info = Join(ary, vbnewline)
Debug.Print info

End Sub

 

[PanzerRanger]

SOLVED

By DIM ary as variant

 

[Jan Mach]

NO!!! Declare ary as date array:
Dim ary() as Date
Why do you all sooo like ugly and slow variant type?

By the way, your declaration

Dim nr, a, c As Integer​

means

Dim nr As Variant, a As Variant, c As Integer
You must write
Dim nr As Integer, a As Integer, c As Integer​

or better

Dim nr%, a%, c%​

And working with integers is not good idea when you need longs! Hence
Dim nr&, a&, c&

is best.


​

​

<strike></strike>

 

[Dryver14]

Jan,

Are you a very strict headmistress on the side.

We are all at various stages of learning here, some better than others, when I code for someone, no one gets angry at what I put, they (often) suggest better coding.

It's then for me to read that code and then learn from if it if I wish. Which I do.