DAO Recordset Edit command not running

[oldcitycat]

First and foremost this is my first attempt at using a recordset!
With that in mind I did my researched and thought I understood but this issue has me stumped.

The code works up to rs.edit statement
I have verified that the If statement is true by stepping through the code,
When it gets to the rs.edit it jumps to end if, No error messages
The one thing I unsure of is if the recordset is locked by default when opened.

Sub CodeTesting()Dim db As Database
Dim rs As DAO.Recordset
Dim strNotes As String
Dim strOrderNumber As String

    Set db = CurrentDb
    Set rs = db.OpenRecordset("DailyMopOrds")

    rs.MoveFirst
    Do Until rs.EOF
    
    If rs!Notes <> " " Then
        strNotes = rs!Notes
        strOrderNumber = rs!OrderNumber
        rs.MoveNext
    End If
    
    If rs!Notes = "" And rs!OrderNumber = strOrderNumber Then
        rs.Edit
        rs!Notes = strNotes
        rs.Update
End If
        rs.MoveNext
Loop
End Sub

Sample Data

OrderNumber	OrderDate	PONumber	Notes
M5014365	2/27/2017	AF373C/MAR17	****MARCH ORDER SHIP AFTER THE 1st***
M5014365	2/27/2017	AF373C/MAR17
M5014366	2/27/2017	AF0C70/MAR17	***MARCH ORDER SHIP AFTER THE 1st**
M5014367	2/27/2017	AF1510/APR17	****APRIL ORDER PLEASE SHIP AFTER 4/1****
M5014367	2/27/2017	AF1510/APR17

<tbody>
</tbody>

Thank you in advance for any and all suggestions
OldCitCat

 

[Micron]

you should test for 0 records else rs.MoveFirst will generate an error if BOF and EOF are true (zero records).
Is it possible that Notes contains one space? " " Or are you trying to test for an empty string?
What is the value of rs.Notes since you say the test is passing?
Which If test are you referring to? You're testing for 2 different values in those tests; " " and ""
Step through the code and in the Immediate window, test each rs.field or variable after the line has been processed. Such as ?rs.Notes, then hit Enter.

 

[xenou]

Do this with SQL

 

[xenou]

Note: or better yet, don't do it at all. You should not have duplicated notes saved in you database as this introduces the danger of data anomalies. Why are your notes being stored this way?

Also, btw, note text is notoriously bad data to work with (you get newlines, tabs, strange characters of all kinds, even invisible characters copied in from web pages). So unless your notes are machine generated, this could be ugly someday.

Also btw your code works fine for me - at least, no errors and the updates succeed.