Correct way of getting % Of (Power BI Desktop) - Measure

[MarkCBB]

Hello,

I am busy messing around with some data to improve my DAX. I am using a very simple table (2 Columns, Column 1 = Product, Column 2 = Sales). (Note, unique list of products)

I am trying to get the percent of each Product i.e. sales contribution. When I create a pie chart with the 2 columns I get the expected result, the values are based on the value of the sum of sales.

Now I am trying to get the values in the Pie chart to show the percentage. I came up with the below Dax measure, and it works, but I am sure that there is a better way of doing this.

% of = DIVIDE(CALCULATE(SUM(Sheet1[Sales]),FIRSTNONBLANK(Sheet1[Products],SUM(Sheet1[Sales]))),CALCULATE(SUM(Sheet1[Sales]),ALL(Sheet1[Products])),0)

 

[Matt Allington]

Try this

divide (sum(sheet1[sales]),calulate(sum(sheet1[sales]),all(sheet1)))

the he first half of divide returns the product total. The second half returns the table total.

 

[MarkCBB]

Thank you Matt, that is perfect. and works on other items besides Product.
Thank you once again for your on going assistance.
I am having so much fun learning DAX