Copy data from a workbook and paste values into another workbook

[racheltaylor]

Hi

I need to copy and paste the values of certain columns from one workbook to different columns in another workbook. See my code below..
I know this code is not efficient, I am new to VBA and would appreciate any help to make my macro more efficient..
I could start copying from row 2 instead of 1, however the end of the range is variable and includes blank cells and I am not sure how to reflect this in my code..


Sub CopyDataToCombinedRegister()


Dim Obook As Workbook
Dim DBook As Workbook


Set Obook = workbooks("General Checks.xlsm")
Set DBook = workbooks("Aged & General Checks V10.xlsx")


Dim wsd As Worksheet
Dim wsc As Worksheet


Set wsd = workbooks("Test.xlsm").Worksheets("sheet1")
Set wsc = workbooks("Aged & General Checks V10 25.01.11test (1).xlsx").Worksheets("sheet1")


wsd.Activate


Range("A:A").Select
Selection.Copy
wsc.Activate
Range("A1").Select
Selection.PasteSpecial Paste:=xlPasteValues

wsd.Activate
Range("E:E,F:F,G:G").Select
Selection.Copy
wsc.Activate
Range("D1").Select
Selection.PasteSpecial Paste:=xlPasteValues

wsd.Activate
Range("L:L").Select
Selection.Copy
wsc.Activate
Range("K1").Select
Selection.PasteSpecial Paste:=xlPasteValues

wsd.Activate
Range("U:U,V:V,W:W").Select
Selection.Copy

wsc.Activate
Range("L1").Activate
Selection.PasteSpecial Paste:=xlPasteValues


End Sub

 

[racheltaylor]

I also know it's not necessary to activate sheets continuously like I have done..
basically I need the below

Column "A" to be copy pasted to column "A"
Columns "E, F, G" to copy pasted to columns "D, E, F" (in that order)
Column "L" to be copy pasted to column "K"
Columns "U, V, W" to be copy pasted to columns "L, M, N" (in that order"

I am copying columns because the range is variable and I'm not sure how to define this.. i.e. Data in column A actually starts in row two, the range contains blanks (as do some but not all of my ranges) and the last cell to the range is variable...because blanks are included in the range i'm not sure how to write a code that includes the blanks....hence the copying of the entire column..

Any help with this is much appreciated!