Convert 32 bit to 64 bit

[tiredofit]

In this article:

https://www.py4u.net/discuss/1448003

it states to convert from 32 bit to 64 bit:

Manually add PtrSafe to all declarations. Manually convert all Longs in the declarations that represent pointers to LongPtrs (in the code shown, that would be only pidl).

Manually update declarations of Long variables in procedures that are passed as these parameters to LongPtr. There's no other way. You may try to look into refactoring tools/addins that may automate the replacements to a degree.

This is the code:

Declare Function SHGetPathFromIDList Lib "shell32.dll" Alias "SHGetPathFromIDListA" (ByVal pidl As Long, ByVal pszPath As String) As Long
Declare Function SHBrowseForFolder Lib "shell32.dll" Alias "SHBrowseForFolderA" (lpBrowseInfo As BROWSEINFO) As Long

So I suppose it should be changed to:

Declare Function SHGetPathFromIDList Lib "shell32.dll" Alias "SHGetPathFromIDListA" (ByVal pidl As LONGPTRS, ByVal pszPath As String) As Long
Declare Function SHBrowseForFolder Lib "shell32.dll" Alias "SHBrowseForFolderA" (lpBrowseInfo As BROWSEINFO) As Long

My question is: why does the "other" Long (at the end of the first line) not need to also change to LongPtr?

In another article:

https://stackoverflow.com/questions/42557610/how-to-convert-32-bit-vba-code-into-64-bit-vba-code

it states it must change from:

Private Declare Function GetTimeZoneInformation Lib "kernel32" ( _
           lpTimeZoneInformation As TIME_ZONE_INFORMATION) As Long

to this:

Private Declare PtrSafe Function GetTimeZoneInformation Lib "kernel32" ( _
       lpTimeZoneInformation As TIME_ZONE_INFORMATION) As LongPtr

Furthermore, other than changing APIs (and removing ActiveX objects), what else must one do to make VBA run on both 32 bit and 64 bit Excel?

Thanks

 

[RoryA]

First, it's LongPtr not LONGPTRS

Second, as stated, you only change pointers (including window handles), not all Long variables. The SO linked answer is wrong.

 

[tiredofit]

First, it's LongPtr not LONGPTRS

Second, as stated, you only change pointers (including window handles), not all Long variables. The SO linked answer is wrong.

Thanks, my typo error re LongPtr.

 

[John_w]

You omitted the PtrSafe keyword from the 64-bit declarations:

#If VBA7 Then
    Private Declare PtrSafe Function SHGetPathFromIDListA Lib "shell32.dll" (ByVal pidl As Long, ByVal pszPath As String) As Long
    Private Declare PtrSafe Function SHBrowseForFolderA Lib "shell32.dll" (lpBrowseInfo As BROWSEINFO) As Long
#Else
    Private Declare Function SHGetPathFromIDListA Lib "shell32.dll" (ByVal pidl As Long, ByVal pszPath As String) As Long
    Private Declare Function SHBrowseForFolderA Lib "shell32.dll" (lpBrowseInfo As BROWSEINFO) As Long
#End If

Window handles and pointers in the BROWSEINFO user-defined type (UDT) must also be changed to LongPtr:

#If VBA7 Then
    Private Type BROWSEINFO
        hOwner As LongPtr
        pidlRoot As Long
        pszDisplayName As String
        lpszTitle As String
        ulFlags As Long
        lpfn As LongPtr
        lParam As LongPtr
        iImage As Long
    End Type
#Else
    Private Type BROWSEINFO
        hOwner As Long
        pidlRoot As Long
        pszDisplayName As String
        lpszTitle As String
        ulFlags As Long
        lpfn As Long
        lParam As Long
        iImage As Long
    End Type
#End If

 

[tiredofit]

You omitted the PtrSafe keyword from the 64-bit declarations:

#If VBA7 Then
    Private Declare PtrSafe Function SHGetPathFromIDListA Lib "shell32.dll" (ByVal pidl As Long, ByVal pszPath As String) As Long
    Private Declare PtrSafe Function SHBrowseForFolderA Lib "shell32.dll" (lpBrowseInfo As BROWSEINFO) As Long
#Else
    Private Declare Function SHGetPathFromIDListA Lib "shell32.dll" (ByVal pidl As Long, ByVal pszPath As String) As Long
    Private Declare Function SHBrowseForFolderA Lib "shell32.dll" (lpBrowseInfo As BROWSEINFO) As Long
#End If

Window handles and pointers in the BROWSEINFO user-defined type (UDT) must also be changed to LongPtr:

#If VBA7 Then
    Private Type BROWSEINFO
        hOwner As LongPtr
        pidlRoot As Long
        pszDisplayName As String
        lpszTitle As String
        ulFlags As Long
        lpfn As LongPtr
        lParam As LongPtr
        iImage As Long
    End Type
#Else
    Private Type BROWSEINFO
        hOwner As Long
        pidlRoot As Long
        pszDisplayName As String
        lpszTitle As String
        ulFlags As Long
        lpfn As Long
        lParam As Long
        iImage As Long
    End Type
#End If

Thanks!